From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH v1 00/16] Bluetooth: Fixes for issues reported by sashiko.dev
Date: Tue, 17 Nov 2026 13:57:21 -0500 [thread overview]
Message-ID: <20261117185737.3758255-1-luiz.dentz@gmail.com> (raw)
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
This series fixes issues reported by sashiko.dev against the Bluetooth
core, each patch carries the identifier of the report(s) it addresses in
its Reported-by tag.
Missing locking around shared state:
- Patch 2 takes hci_req_sync_lock around hci_powered_update_sync() in
hci_power_on().
- Patches 3 and 4 look up advertising instances under hdev->lock in
hci_disable_ext_adv_instance_sync() and
hci_schedule_adv_instance_sync().
- Patch 5 serializes the writers of hdev->link_keys. smp_notify_keys()
runs with the l2cap channel lock held, which is ordered after
hdev->lock, so this adds a dedicated hdev->link_keys_lock instead of
taking hdev->lock there.
- Patch 13 protects the MSFT event prefix with hdev->lock.
- Patch 15 holds hdev->lock while looking up and freeing advertisement
monitors.
- Patch 16 serializes the reparenting of the RFCOMM tty device.
Lifetime issues:
- Patch 11 reworks the mesh transmission handling: mesh_pending and the
advertising instances are accessed under hdev->lock, the cmd_sync
entries carry the transmission handle rather than a pointer to it, and
Mesh Send Cancel and mgmt_cleanup() cancel a transmission the same
way, stopping the done timer if it is the one in progress.
- Patch 12 reads the pending Set Powered command under
mgmt_pending_lock in mgmt_powering_down().
Missing validation:
- Patch 1 sizes the Read Index List reply from all the controllers.
- Patch 6 checks hdev->smp_data before using SMP_DEV().
- Patch 8 validates the length of the sent LE Set Extended Advertising
Enable command before parsing it.
- Patch 9 rejects a zero multi advertising rotation duration.
- Patch 10 only uses the EFS option in l2cap_parse_conf_rsp() if the
response carried one.
debugfs:
- Patch 7 stops force_bredr_smp from creating the BR/EDR SMP channel
while SMP is not registered.
- Patch 14 sets/clears the debugfs controlled flags explicitly rather
than toggling them, and serializes the writers.
Known limitation: in patch 11, if the done timer has already fired when a
transmission is cancelled, mesh_send_done_sync() can still complete the
next transmission early.
Testing: an earlier revision of the series was run with KASAN and lockdep
enabled through the BlueZ testers (mgmt, mesh, smp, l2cap, rfcomm, iso,
...) and test-functional. This revision, rebased on top of bluetooth-next
with patch 11 reworked, has only been build tested (W=1, each patch).
Luiz Augusto von Dentz (16):
Bluetooth: mgmt: Fix read_index_list() buffer overflow
Bluetooth: hci_core: Take req_sync lock in hci_power_on()
Bluetooth: hci_sync: Lock the lookup in
hci_disable_ext_adv_instance_sync()
Bluetooth: hci_sync: Hold hdev->lock in
hci_schedule_adv_instance_sync()
Bluetooth: SMP: Serialize link key updates from smp_notify_keys()
Bluetooth: SMP: Check smp_data before using SMP_DEV()
Bluetooth: SMP: Don't create the BR/EDR channel while unregistered
Bluetooth: hci_event: Validate sent command length in LE Set Ext Adv
Enable
Bluetooth: mgmt: Reject zero multi advertising rotation duration
Bluetooth: L2CAP: Don't use uninitialized EFS in
l2cap_parse_conf_rsp()
Bluetooth: mgmt: Fix mesh transmission locking and lifetime
Bluetooth: MGMT: Fix use-after-free in mgmt_powering_down()
Bluetooth: MSFT: Protect the event prefix with hdev->lock
Bluetooth: hci_debugfs: Fix racy toggling of debugfs controlled flags
Bluetooth: hci_core: Hold hdev->lock when removing advertisement
monitors
Bluetooth: RFCOMM: Serialize tty device reparenting
include/net/bluetooth/hci_core.h | 4 +
net/bluetooth/hci_core.c | 54 ++++++-
net/bluetooth/hci_debugfs.c | 30 +++-
net/bluetooth/hci_event.c | 9 +-
net/bluetooth/hci_sync.c | 24 ++-
net/bluetooth/l2cap_core.c | 5 +-
net/bluetooth/mgmt.c | 262 +++++++++++++++++++++++++------
net/bluetooth/mgmt_config.c | 6 +
net/bluetooth/msft.c | 29 ++--
net/bluetooth/rfcomm/tty.c | 21 ++-
net/bluetooth/smp.c | 58 +++++--
11 files changed, 406 insertions(+), 96 deletions(-)
base-commit: 3c5963d23d64972385786e0be47be16d89ff4434
--
2.56.0
next reply other threads:[~2026-11-17 18:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 18:57 Luiz Augusto von Dentz [this message]
2026-11-17 18:57 ` [PATCH v1 01/16] Bluetooth: mgmt: Fix read_index_list() buffer overflow Luiz Augusto von Dentz
2026-11-17 20:13 ` Bluetooth: Fixes for issues reported by sashiko.dev bluez.test.bot
2026-11-17 18:57 ` [PATCH v1 02/16] Bluetooth: hci_core: Take req_sync lock in hci_power_on() Luiz Augusto von Dentz
2026-11-17 18:57 ` [PATCH v1 03/16] Bluetooth: hci_sync: Lock the lookup in hci_disable_ext_adv_instance_sync() Luiz Augusto von Dentz
2026-11-17 18:57 ` [PATCH v1 04/16] Bluetooth: hci_sync: Hold hdev->lock in hci_schedule_adv_instance_sync() Luiz Augusto von Dentz
2026-11-17 18:57 ` [PATCH v1 05/16] Bluetooth: SMP: Serialize link key updates from smp_notify_keys() Luiz Augusto von Dentz
2026-11-17 18:57 ` [PATCH v1 06/16] Bluetooth: SMP: Check smp_data before using SMP_DEV() Luiz Augusto von Dentz
2026-11-17 18:57 ` [PATCH v1 07/16] Bluetooth: SMP: Don't create the BR/EDR channel while unregistered Luiz Augusto von Dentz
2026-11-17 18:57 ` [PATCH v1 08/16] Bluetooth: hci_event: Validate sent command length in LE Set Ext Adv Enable Luiz Augusto von Dentz
2026-11-17 18:57 ` [PATCH v1 09/16] Bluetooth: mgmt: Reject zero multi advertising rotation duration Luiz Augusto von Dentz
2026-11-17 18:57 ` [PATCH v1 10/16] Bluetooth: L2CAP: Don't use uninitialized EFS in l2cap_parse_conf_rsp() Luiz Augusto von Dentz
2026-11-17 18:57 ` [PATCH v1 11/16] Bluetooth: mgmt: Fix mesh transmission locking and lifetime Luiz Augusto von Dentz
2026-11-17 18:57 ` [PATCH v1 12/16] Bluetooth: MGMT: Fix use-after-free in mgmt_powering_down() Luiz Augusto von Dentz
2026-11-17 18:57 ` [PATCH v1 13/16] Bluetooth: MSFT: Protect the event prefix with hdev->lock Luiz Augusto von Dentz
2026-11-17 18:57 ` [PATCH v1 14/16] Bluetooth: hci_debugfs: Fix racy toggling of debugfs controlled flags Luiz Augusto von Dentz
2026-11-17 18:57 ` [PATCH v1 15/16] Bluetooth: hci_core: Hold hdev->lock when removing advertisement monitors Luiz Augusto von Dentz
2026-11-17 18:57 ` [PATCH v1 16/16] Bluetooth: RFCOMM: Serialize tty device reparenting Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117185737.3758255-1-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox