From: Simon Mikuda <simon.mikuda@streamunlimited.com>
To: linux-bluetooth@vger.kernel.org
Cc: Simon Mikuda <simon.mikuda@streamunlimited.com>
Subject: [PATCH BlueZ] advertising: Refresh only advertisements that depend on discoverable
Date: Sun, 22 Nov 2026 11:31:24 +0100 [thread overview]
Message-ID: <20261122103136.620031-1-simon.mikuda@streamunlimited.com> (raw)
A change of the discoverable setting sets every advertisement again,
although only a peripheral one without its own Flags depends on it.
Some controllers can disturb a running BIG when the advertising set
of its broadcast source is restarted (an NXP one skips every third BIG
event after it).
Steps to reproduce:
1. Start a broadcast source whose announcement is a registered
advertisement (LEAdvertisingManager1, Type "broadcast").
2. bluetoothctl discoverable on
3. The advertising set of the broadcast is disabled and enabled again
(btmon), under the BIG.
Fixes: 91d4b17160b8 ("advertising: Configure discoverable flag based on adapter settings")
Assisted-by: Claude:claude-opus-5-5
---
src/advertising.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/advertising.c b/src/advertising.c
index b68ff28f5..d07068c6c 100644
--- a/src/advertising.c
+++ b/src/advertising.c
@@ -2180,6 +2180,10 @@ static void manager_refresh(void *data, void *user_data)
{
struct btd_adv_client *client = data;
+ /* Only a peripheral without its own Flags depends on discoverable */
+ if (client->type != AD_TYPE_PERIPHERAL || bt_ad_has_flags(client->data))
+ return;
+
refresh_advertisement(client, NULL);
}
base-commit: 1adfe662efeff12997df9ddd0960dbd0de9c8ea7
--
2.43.0
next reply other threads:[~2026-11-22 10:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-22 10:31 Simon Mikuda [this message]
2026-11-22 18:47 ` [BlueZ] advertising: Refresh only advertisements that depend on discoverable bluez.test.bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261122103136.620031-1-simon.mikuda@streamunlimited.com \
--to=simon.mikuda@streamunlimited.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).