From: Simon Mikuda <simon.mikuda@streamunlimited.com>
To: linux-bluetooth@vger.kernel.org
Cc: Simon Mikuda <simon.mikuda@streamunlimited.com>
Subject: [PATCH BlueZ 0/8] AVRCP browsing fixes, and browsing and cover art in the target role
Date: Sun, 22 Nov 2026 11:57:23 +0100 [thread overview]
Message-ID: <20261122105731.799090-1-simon.mikuda@streamunlimited.com> (raw)
Patches 1-11 fix the AVRCP browsing code, mostly in the controller
role: the browsing PDU parameter length is not checked against the
bytes received, the media player list cannot be read up to item
0xffffffff, ADDRESSED_PLAYER_CHANGED and TRACK_CHANGED are sent in the
wrong byte order, a player addressed before it was listed is never
browsed, Search in a folder whose name has a space crashes bluetoothd,
and listed Now Playing items lose their Name and NumberOfItems. Each
patch has its reproduction steps and the logs it showed. A unit test
and a functional test (with its documentation) cover two of them.
Patches 12-13 prepare avctp to answer a browsing command later, from a
D-Bus reply.
Patches 14-22 add browsing in the target role: a local player
registered with org.bluez.Media1.RegisterPlayer can expose a folder
tree (org.bluez.MediaFolder1 and org.bluez.MediaItem1 on the
application's objects), which a remote controller browses, and cover
art, offered in the target record for a player that registers an
ObexPort. Documentation, the D-Bus
policy and a functional test come with them.
Testing: every patch builds in maintainer mode (-Werror, ASan/UBSan)
and the unit tests CI maps to these files pass (make check). The series
was developed and tried against phones and other BlueZ controllers on
an earlier base (2026-10-12); rebased on this one it was build- and
unit-tested only, and the functional tests (test/test-functional) were
not run for this version. Valgrind, scan-build and distcheck were not
run.
Not included: the GetTotalNumberOfItems parameter length fix of the
earlier version, as a80671987 ("avrcp: Fix GetTotalNumberOfItems
command encoding") fixed the same thing.
AI assistance: Claude (claude-opus-5-5) was used for analysis, code,
tests and the commit messages; every patch carries Assisted-by.
Simon Mikuda (8):
avrcp: Fix not checking browsing PDU parameter length
avrcp: Fix listing media players up to item 0xffffffff
avrcp: Fix byte order of ADDRESSED_PLAYER_CHANGED notification
avrcp: Fix byte order of TRACK_CHANGED identifier
avrcp: Fix not browsing a player addressed before it was listed
player: Fix crash on Search in a folder with a space in its name
player: Fix missing Name of listed Now Playing items
player: Fix NumberOfItems of Now Playing after its content changed
profiles/audio/avrcp.c | 35 +++++++++++++++++-----
profiles/audio/player.c | 66 ++++++++++++++++++++++++++++++++++++++---
2 files changed, 90 insertions(+), 11 deletions(-)
base-commit: 1adfe662efeff12997df9ddd0960dbd0de9c8ea7
--
2.43.0
next reply other threads:[~2026-11-22 10:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-22 10:57 Simon Mikuda [this message]
2026-11-22 10:57 ` [PATCH BlueZ 1/8] avrcp: Fix not checking browsing PDU parameter length Simon Mikuda
2026-11-22 18:57 ` AVRCP browsing fixes, and browsing and cover art in the target role bluez.test.bot
2026-11-22 10:57 ` [PATCH BlueZ 2/8] avrcp: Fix listing media players up to item 0xffffffff Simon Mikuda
2026-11-22 10:57 ` [PATCH BlueZ 3/8] avrcp: Fix byte order of ADDRESSED_PLAYER_CHANGED notification Simon Mikuda
2026-11-22 10:57 ` [PATCH BlueZ 4/8] avrcp: Fix byte order of TRACK_CHANGED identifier Simon Mikuda
2026-11-22 10:57 ` [PATCH BlueZ 5/8] avrcp: Fix not browsing a player addressed before it was listed Simon Mikuda
2026-11-22 10:57 ` [PATCH BlueZ 6/8] player: Fix crash on Search in a folder with a space in its name Simon Mikuda
2026-11-22 10:57 ` [PATCH BlueZ 7/8] player: Fix missing Name of listed Now Playing items Simon Mikuda
2026-11-22 10:57 ` [PATCH BlueZ 8/8] player: Fix NumberOfItems of Now Playing after its content changed Simon Mikuda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261122105731.799090-1-simon.mikuda@streamunlimited.com \
--to=simon.mikuda@streamunlimited.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox