From: Szymon Janc <szymon.janc@tieto.com>
To: Jakub Tyszkowski <jakub.tyszkowski@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] android/client: Allow zero length responses
Date: Wed, 28 May 2014 11:28:47 +0200 [thread overview]
Message-ID: <2085513.UkBDmqa62f@uw000953> (raw)
In-Reply-To: <1401268747-21901-1-git-send-email-jakub.tyszkowski@tieto.com>
Hi Jakub,
On Wednesday 28 of May 2014 11:19:06 Jakub Tyszkowski wrote:
> ---
> android/client/if-gatt.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/android/client/if-gatt.c b/android/client/if-gatt.c
> index 252e89d..0375126 100644
> --- a/android/client/if-gatt.c
> +++ b/android/client/if-gatt.c
> @@ -1772,15 +1772,11 @@ static void gatts_send_response_p(int argc, const char *argv[])
> data.attr_value.auth_req = 0;
> data.attr_value.len = 0;
>
> - if (argc <= 7) {
> - haltest_error("No data specified\n");
> - return;
> - }
> -
> - data.attr_value.len = strlen(argv[7]);
> - scan_field(argv[7], data.attr_value.len, data.attr_value.value,
> + if (argc > 7) {
> + data.attr_value.len = strlen(argv[7]);
> + scan_field(argv[7], data.attr_value.len, data.attr_value.value,
> sizeof(data.attr_value.value));
> -
> + }
>
> haltest_info("conn_id %d, trans_id %d, status %d", conn_id, trans_id,
> status);
This patch is now applied, thanks.
--
Best regards,
Szymon Janc
prev parent reply other threads:[~2014-05-28 9:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 9:19 [PATCH 1/2] android/client: Allow zero length responses Jakub Tyszkowski
2014-05-28 9:19 ` [PATCH 2/2] android/pts: Update GATT PTS results Jakub Tyszkowski
2014-05-28 9:28 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2085513.UkBDmqa62f@uw000953 \
--to=szymon.janc@tieto.com \
--cc=jakub.tyszkowski@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).