From: Szymon Janc <szymon.janc@tieto.com>
To: Marcin Kraglak <marcin.kraglak@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCHv2 01/11] shared/hfp: Fix not freeing cmd_handler prefix
Date: Thu, 06 Mar 2014 10:21:47 +0100 [thread overview]
Message-ID: <2289016.VB6flxH51s@uw000953> (raw)
In-Reply-To: <1394047376-11495-1-git-send-email-marcin.kraglak@tieto.com>
Hi Marcin,
On Wednesday 05 of March 2014 20:22:46 Marcin Kraglak wrote:
> It should be freed while destroy.
> ---
> src/shared/hfp.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/shared/hfp.c b/src/shared/hfp.c
> index 08393d8..9523243 100644
> --- a/src/shared/hfp.c
> +++ b/src/shared/hfp.c
> @@ -82,6 +82,8 @@ static void destroy_cmd_handler(void *data)
> if (handler->destroy)
> handler->destroy(handler->user_data);
>
> + free(handler->prefix);
> +
> free(handler);
> }
>
All patches applied, thanks.
--
Best regards,
Szymon Janc
next prev parent reply other threads:[~2014-03-06 9:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 19:22 [PATCHv2 01/11] shared/hfp: Fix not freeing cmd_handler prefix Marcin Kraglak
2014-03-05 19:22 ` [PATCHv2 02/11] unit: Initial version of test-hfp Marcin Kraglak
2014-03-05 19:22 ` [PATCHv2 03/11] unit/test-hfp: Add /hfp/test_cmd_handler_1 Marcin Kraglak
2014-03-05 19:22 ` [PATCHv2 04/11] unit/test-hfp: Add /hfp/test_cmd_handler_2 Marcin Kraglak
2014-03-05 19:22 ` [PATCHv2 05/11] unit/test-hfp: Add /hfp/test_register_1 Marcin Kraglak
2014-03-05 19:22 ` [PATCHv2 06/11] unit/test-hfp: Add /hfp/test_register_2 Marcin Kraglak
2014-03-05 19:22 ` [PATCHv2 07/11] unit/test-hfp: Add /hfp/test_register_3 Marcin Kraglak
2014-03-05 19:22 ` [PATCHv2 08/11] unit/test-hfp: Add /hfp/test_register_4 Marcin Kraglak
2014-03-05 19:22 ` [PATCHv2 09/11] unit/test-hfp: Add /hfp/test_register_5 Marcin Kraglak
2014-03-05 19:22 ` [PATCHv2 10/11] unit/test-hfp: Add /hfp/test_fragmented_1 Marcin Kraglak
2014-03-05 19:22 ` [PATCHv2 11/11] shared/hfp: Don't try read uninitialized data in ringbuffer Marcin Kraglak
2014-03-06 9:21 ` Szymon Janc [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-03-04 12:28 [PATCHv2 01/11] shared/hfp: Fix not freeing cmd_handler prefix Marcin Kraglak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2289016.VB6flxH51s@uw000953 \
--to=szymon.janc@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcin.kraglak@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox