Re: obexd/pbap: Update PSE support from PBAP 1.1 to 1.2

[Jinwang Li <jinwang.li@oss.qualcomm.com>]

Hi Luiz,

On 11/9/2026 10:31 PM, Luiz Augusto von Dentz wrote:
> Hi Jinwang,
> 
> On Mon, Nov 9, 2026 at 4:34 AM Jinwang Li <jinwang.li@oss.qualcomm.com> wrote:
>>
>>
>>
>> On 11/5/2026 11:37 PM, Luiz Augusto von Dentz wrote:
>>> Hi Jinwang,
>>>
>>> On Wed, Nov 4, 2026 at 12:14 PM <bluez.test.bot@gmail.com> wrote:
>>>>
>>>> This is automated email and please do not reply to this email!
>>>>
>>>> Dear submitter,
>>>>
>>>> Thank you for submitting the patches to the linux bluetooth mailing list.
>>>> This is a CI test results with your patch series:
>>>> PW Link:https://patchwork.kernel.org/series/1201470/
>>>>
>>>> ---Test result---
>>>>
>>>> Test Summary:
>>>> CheckPatch                    PASS      8.55 seconds
>>>> GitLint                       PASS      4.70 seconds
>>>> BuildEll                      PASS      23.33 seconds
>>>> BluezMake                     PASS      197.66 seconds
>>>> MakeCheck                     PASS      13.22 seconds
>>>> MakeDistcheck                 PASS      105.32 seconds
>>>> CheckValgrind                 PASS      164.16 seconds
>>>> CheckSmatch                   PASS      173.53 seconds
>>>> bluezmakeextell               PASS      69.20 seconds
>>>> TestFunctional                PASS      885.71 seconds
>>>> IncrementalBuild              PASS      250.73 seconds
>>>> ScanBuild                     PASS      687.43 seconds
>>>>
>>>>
>>>>
>>>> https://github.com/bluez/bluez/pull/2760
>>>>
>>>> ---
>>>> Regards,
>>>> Linux Bluetooth
>>>
>>> Copilot flagged a couple of problems:
>>> https://github.com/bluez/bluez/pull/2760#pullrequestreview-5775992507
>> Hi Luiz,
>>
>> The first three comments are valid. v2 will fix all three.
>>
>> I would also like to discuss comment 4, "Clear JPEG image capability
>> until photos are normalized."
>>
>> The Default Contact Image Format feature is mandatory for PBAP 1.2 and
>> requires PHOTO to contain a base64-encoded JPEG of at most 300x300
>> pixels and 50 kB.
>>
>> The three backends currently handle photos differently: Tracker uses the
>> photo URL directly, ebook passes through inline data or a URI, and dummy
>> forwards the PHOTO value from the vCard. This series only advertises the
>> feature bit and does not change these behaviors.
>>
>> I don't think obexd should perform remote network access, image
>> resizing, or transcoding, as that would add unrelated networking and
>> image-processing dependencies.
>>
>> Without those, I see three options:
>>
>> Keep the existing behavior and only advertise bit 9.
>> Validate inline PHOTO data and omit non-conformant or URI-based images.
>> Read local photo URIs, base64-encode JPEGs that meet the requirements,
>> and omit unsupported or non-conformant images.
>>
>> Do you have a preference for how this should be handled?
> 
> I don't have a particular preference, it just needs to be spec
> compliant and pass the PTS testing. If each backend uses a different
> format or method, perhaps we need to converge on one. That said, I
> don't think the Linux desktop cares too much about PBAP so perhaps
> this is just to exercise whether PBAP could be qualified? In that case
> I would just use the dummy format, or read it locally and then check
> if it meets the requirements.

The main purpose of these changes is to pass the PTS tests, as PBAP 
1.1.1 is scheduled to be deprecated on 2028-02-01. I'll update the 
implementation accordingly and send a v2.

>