From: Szymon Janc <szymon.janc@tieto.com>
To: Jakub Tyszkowski <jakub.tyszkowski@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/6] android/gatt: Remove redundant search
Date: Wed, 11 Feb 2015 12:27:42 +0100 [thread overview]
Message-ID: <2356699.pYCfEUalJd@uw000953> (raw)
In-Reply-To: <1423572494-32037-1-git-send-email-jakub.tyszkowski@tieto.com>
Hi Jakub,
On Tuesday 10 of February 2015 13:48:09 Jakub Tyszkowski wrote:
> Searching for device is not needed since we have reference counting and
> device is there as long as app connection exist.
> ---
> android/gatt.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/android/gatt.c b/android/gatt.c
> index 4398194..425d3e8 100644
> --- a/android/gatt.c
> +++ b/android/gatt.c
> @@ -914,14 +914,10 @@ static void destroy_connection(void *data)
> if (conn->timeout_id > 0)
> g_source_remove(conn->timeout_id);
>
> - if (!queue_find(gatt_devices, match_by_value, conn->device))
> - goto cleanup;
> -
> conn->device->conn_cnt--;
> if (conn->device->conn_cnt == 0)
> connection_cleanup(conn->device);
>
> -cleanup:
> queue_destroy(conn->transactions, free);
> device_unref(conn->device);
> free(conn);
>
All patches applied, thanks.
--
Best regards,
Szymon Janc
prev parent reply other threads:[~2015-02-11 11:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 12:48 [PATCH 1/6] android/gatt: Remove redundant search Jakub Tyszkowski
2015-02-10 12:48 ` [PATCH 2/6] android/gatt: Remove REQUEST_INIT state Jakub Tyszkowski
2015-02-10 12:48 ` [PATCH 3/6] android/gatt: Minor debug message change Jakub Tyszkowski
2015-02-10 12:48 ` [PATCH 4/6] android/gatt: Minor function renames Jakub Tyszkowski
2015-02-10 12:48 ` [PATCH 5/6] android/gatt: Remove reduntant comparison Jakub Tyszkowski
2015-02-10 12:48 ` [PATCH 6/6] android/gatt: Remove device's connection counter Jakub Tyszkowski
2015-02-11 11:27 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2356699.pYCfEUalJd@uw000953 \
--to=szymon.janc@tieto.com \
--cc=jakub.tyszkowski@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox