From: Szymon Janc <szymon.janc@tieto.com>
To: Jakub Tyszkowski <jakub.tyszkowski@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] android/gatt: Support find request in permission check
Date: Fri, 30 May 2014 16:47:33 +0200 [thread overview]
Message-ID: <23756045.JH0hgDSIYx@leonov> (raw)
In-Reply-To: <1401455982-31339-1-git-send-email-jakub.tyszkowski@tieto.com>
Hi Jakub,
On Friday 30 of May 2014 15:19:41 Jakub Tyszkowski wrote:
> Permissions check was failing on those requests.
> ---
> android/gatt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/android/gatt.c b/android/gatt.c
> index fcc91ff..a61d702 100644
> --- a/android/gatt.c
> +++ b/android/gatt.c
> @@ -4007,6 +4007,8 @@ static uint8_t check_device_permissions(struct
> gatt_device *device, case ATT_OP_READ_BLOB_REQ:
> case ATT_OP_READ_MULTI_REQ:
> case ATT_OP_READ_BY_GROUP_REQ:
> + case ATT_OP_FIND_BY_TYPE_REQ:
> + case ATT_OP_FIND_INFO_REQ:
> if (!(permissions & GATT_PERM_READ))
> return ATT_ECODE_READ_NOT_PERM;
Both patches applied, thanks.
--
BR
Szymon Janc
prev parent reply other threads:[~2014-05-30 14:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 13:19 [PATCH 1/2] android/gatt: Support find request in permission check Jakub Tyszkowski
2014-05-30 13:19 ` [PATCH 2/2] android/gatt: Fix not setting request as done on direct db read Jakub Tyszkowski
2014-05-30 14:47 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23756045.JH0hgDSIYx@leonov \
--to=szymon.janc@tieto.com \
--cc=jakub.tyszkowski@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).