From: Szymon Janc <szymon.janc@tieto.com>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] hfp: Fix memory leak
Date: Thu, 30 Oct 2014 10:30:28 +0100 [thread overview]
Message-ID: <24392477.JhYW2PpoS6@leonov> (raw)
In-Reply-To: <1414502910-19950-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>
Hi Andrei,
On Tuesday 28 of October 2014 15:28:30 Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> Free fmt allocated by asprintf().
> ---
> src/shared/hfp.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/shared/hfp.c b/src/shared/hfp.c
> index 22e9622..9a66ed2 100644
> --- a/src/shared/hfp.c
> +++ b/src/shared/hfp.c
> @@ -1321,8 +1321,10 @@ bool hfp_hf_send_command(struct hfp_hf *hfp,
> hfp_response_func_t resp_cb, return false;
>
> cmd = new0(struct cmd_response, 1);
> - if (!cmd)
> + if (!cmd) {
> + free(fmt);
> return false;
> + }
>
> va_start(ap, format);
> len = ringbuf_vprintf(hfp->write_buf, fmt, ap);
Patch applied after fixing commit prefix, thanks.
--
BR
Szymon Janc
prev parent reply other threads:[~2014-10-30 9:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 13:28 [PATCH] hfp: Fix memory leak Andrei Emeltchenko
2014-10-30 9:30 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24392477.JhYW2PpoS6@leonov \
--to=szymon.janc@tieto.com \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox