Linux bluetooth development
 help / color / mirror / Atom feed
From: Szymon Janc <szymon.janc@tieto.com>
To: Jakub Tyszkowski <jakub.tyszkowski@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] android/hal-gatt: Fix wrong pointer usage
Date: Mon, 17 Mar 2014 10:56:07 +0100	[thread overview]
Message-ID: <2450870.7vSUfPZSpG@leonov> (raw)
In-Reply-To: <1395044442-14350-1-git-send-email-jakub.tyszkowski@tieto.com>

Hi Jakub,

On Monday 17 of March 2014 09:20:41 Jakub Tyszkowski wrote:
> ---
>  android/hal-gatt.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/android/hal-gatt.c b/android/hal-gatt.c
> index 8f906fd..bd61576 100644
> --- a/android/hal-gatt.c
> +++ b/android/hal-gatt.c
> @@ -683,7 +683,7 @@ static bt_status_t get_descriptor(int conn_id,
> btgatt_srvc_id_t *srvc_id,
> 
>  	return hal_ipc_cmd(HAL_SERVICE_ID_GATT,
>  					HAL_OP_GATT_CLIENT_GET_DESCRIPTOR,
> -					len, &cmd, 0 , NULL, NULL);
> +					len, cmd, 0 , NULL, NULL);
>  }
> 
>  static bt_status_t read_characteristic(int conn_id, btgatt_srvc_id_t
> *srvc_id, @@ -1065,7 +1065,7 @@ static bt_status_t send_indication(int
> server_if, int attribute_handle,
> 
>  	return hal_ipc_cmd(HAL_SERVICE_ID_GATT,
>  					HAL_OP_GATT_SERVER_SEND_INDICATION,
> -					cmd_len, &cmd, 0, NULL, NULL);
> +					cmd_len, cmd, 0, NULL, NULL);
>  }
> 
>  static bt_status_t send_response(int conn_id, int trans_id, int status,
> @@ -1084,7 +1084,7 @@ static bt_status_t send_response(int conn_id, int
> trans_id, int status,
> 
>  	return hal_ipc_cmd(HAL_SERVICE_ID_GATT,
>  					HAL_OP_GATT_SERVER_SEND_RESPONSE,
> -					cmd_len, &cmd, 0, NULL, NULL);
> +					cmd_len, cmd, 0, NULL, NULL);
>  }
> 
>  static bt_status_t init(const btgatt_callbacks_t *callbacks)

Both patches applied. Thanks.

-- 
BR
Szymon Janc

      parent reply	other threads:[~2014-03-17  9:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-17  8:20 [PATCH 1/2] android/hal-gatt: Fix wrong pointer usage Jakub Tyszkowski
2014-03-17  8:20 ` [PATCH 2/2] android/hal-ipc: Make opcode debug print more readable Jakub Tyszkowski
2014-03-17  9:56 ` Szymon Janc [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2450870.7vSUfPZSpG@leonov \
    --to=szymon.janc@tieto.com \
    --cc=jakub.tyszkowski@tieto.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox