Linux bluetooth development
 help / color / mirror / Atom feed
From: Szymon Janc <szymon.janc@tieto.com>
To: Johan Hedberg <johan.hedberg@gmail.com>
Cc: linux-bluetooth@vger.kernel.org, Szymon Janc <szymon.janc@gmail.com>
Subject: Re: [PATCH RESEND] client: Clean up agent if bluetoothd exited without releasing it
Date: Mon, 28 Apr 2014 11:20:33 +0200	[thread overview]
Message-ID: <2465782.SFzOROTRxg@uw000953> (raw)
In-Reply-To: <20140428082236.GA32279@t440s.lan>

Hi Johan,

On Monday 28 of April 2014 11:22:36 Johan Hedberg wrote:
> Hi Szymon,
> 
> On Fri, Apr 25, 2014, Szymon Janc wrote:
> > If bluetoothd exited without releasing agent (eg. due to crash) it was
> > not possible to register client as agent after daemon was restarted.
> > ---
> >  client/agent.c | 21 +++++++++++++++++++--
> >  1 file changed, 19 insertions(+), 2 deletions(-)
> 
> Since client/main.c is already doing tracking or org.bluez I think it
> might make more sense to do the agent clearing from there, maybe by
> adding an agent_clear function to agent.c and then calling it from
> disconnect_handler in main.c. Thoughts?

There is patch from Luiz that does exactly this and I'm fine with applying it
instead.

"[PATCH BlueZ 2/3] client: Fix not releasing agent if bluetoothd exit without
calling Release" from 26.11.2013.

-- 
Best regards, 
Szymon Janc

      reply	other threads:[~2014-04-28  9:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-25 10:30 [PATCH RESEND] client: Clean up agent if bluetoothd exited without releasing it Szymon Janc
2014-04-28  8:22 ` Johan Hedberg
2014-04-28  9:20   ` Szymon Janc [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2465782.SFzOROTRxg@uw000953 \
    --to=szymon.janc@tieto.com \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=szymon.janc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox