Linux bluetooth development
 help / color / mirror / Atom feed
From: Szymon Janc <szymon.janc@tieto.com>
To: linux-bluetooth@vger.kernel.org
Subject: Re: [RFC] android/handsfree: Send NO CARRIER if call was end due to carrier loss
Date: Wed, 26 Mar 2014 00:16:33 +0100	[thread overview]
Message-ID: <2586579.MBIyHeOiKX@leonov> (raw)
In-Reply-To: <1395686912-10919-1-git-send-email-szymon.janc@tieto.com>

On Monday 24 of March 2014 19:48:32 Szymon Janc wrote:
> This was affecting TC_AG_TCA_BV_06_I qualification test case.
> ---
> 
> I have an impression that this should be handled by telephony stack,
> not BT stack hence sending this as RFC.
> 
> 
>  android/handsfree.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/android/handsfree.c b/android/handsfree.c
> index e1bf563..9b98591 100644
> --- a/android/handsfree.c
> +++ b/android/handsfree.c
> @@ -2093,6 +2093,13 @@ static void phone_state_idle(int num_active, int
> num_held) num_held ? (num_active ? 1 : 2) : 0);
>  		update_indicator(IND_CALL, !!(num_active + num_held));
>  		update_indicator(IND_CALLSETUP, 0);
> +
> +		/* If call was terminated due to carrier lost send NO CARRIER */
> +		if (num_active == 0 && num_held == 0 &&
> +				device.inds[IND_SERVICE].val == 0 &&
> +				(device.num_active > 0 || device.num_held > 0))
> +				hfp_gw_send_info(device.gw, "NO CARRIER");
> +
>  		break;
>  	default:
>  		DBG("unhandled state %u", device.setup_state);

Since PICS were updated to include affected test, this is now upstream.

-- 
BR
Szymon Janc

      reply	other threads:[~2014-03-25 23:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-24 18:48 [RFC] android/handsfree: Send NO CARRIER if call was end due to carrier loss Szymon Janc
2014-03-25 23:16 ` Szymon Janc [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2586579.MBIyHeOiKX@leonov \
    --to=szymon.janc@tieto.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox