From: Szymon Janc <szymon.janc@tieto.com>
To: Lukasz Rymanowski <lukasz.rymanowski@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2 5/5] android/gatt: Fix type of status parameter
Date: Fri, 11 Apr 2014 15:37:29 +0200 [thread overview]
Message-ID: <2675315.WyPcCgPKWo@uw000953> (raw)
In-Reply-To: <1397143805-17809-6-git-send-email-lukasz.rymanowski@tieto.com>
Hi Łukasz,
On Thursday 10 of April 2014 17:30:05 Lukasz Rymanowski wrote:
> ---
> android/gatt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/android/gatt.c b/android/gatt.c
> index 235e9e4..cdca424 100644
> --- a/android/gatt.c
> +++ b/android/gatt.c
> @@ -509,7 +509,7 @@ static void connection_cleanup(struct gatt_device *device)
> }
>
> static void send_client_disconnect_notify(int32_t id, struct gatt_device *dev,
> - uint8_t status)
> + int32_t status)
> {
> struct hal_ev_gatt_client_disconnect ev;
>
>
I've applied this patch, but please check why this function is always called
success status. Shouldn't we call this callback with fail status if
handle_client_disconnect() failed?
--
Best regards,
Szymon Janc
prev parent reply other threads:[~2014-04-11 13:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 15:30 [PATCH v2 0/5]android/gatt: GATT client improvements Lukasz Rymanowski
2014-04-10 15:30 ` [PATCH v2 1/5] android/gatt: Refactor send_client_connect_notify Lukasz Rymanowski
2014-04-11 13:27 ` Szymon Janc
2014-04-11 13:32 ` Lukasz Rymanowski
2014-04-11 13:39 ` Szymon Janc
2014-04-10 15:30 ` [PATCH v2 2/5] android/gatt: Fix handling client unregister Lukasz Rymanowski
2014-04-10 15:30 ` [PATCH v2 3/5] android/gatt: Move functions up in the file Lukasz Rymanowski
2014-04-10 15:30 ` [PATCH v2 4/5] android/gatt: Cleanup device lists Lukasz Rymanowski
2014-04-10 15:30 ` [PATCH v2 5/5] android/gatt: Fix type of status parameter Lukasz Rymanowski
2014-04-11 13:37 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2675315.WyPcCgPKWo@uw000953 \
--to=szymon.janc@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=lukasz.rymanowski@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox