Linux bluetooth development
 help / color / mirror / Atom feed
From: Szymon Janc <szymon.janc@tieto.com>
To: Grzegorz Kolodziejczyk <grzegorz.kolodziejczyk@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2 1/3] android/gatt: Remove redundant hal cmd check
Date: Tue, 01 Apr 2014 15:56:49 +0200	[thread overview]
Message-ID: <26858286.n3DPGo1T2v@uw000953> (raw)
In-Reply-To: <1396356869-21053-1-git-send-email-grzegorz.kolodziejczyk@tieto.com>

Hi Grzegorz,

On Tuesday 01 of April 2014 14:54:27 Grzegorz Kolodziejczyk wrote:
> This removes redundant hal cmd check (is received in cmd UUID == NULL).
> ---
>  android/gatt.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/android/gatt.c b/android/gatt.c
> index 941582a..ee77a4e 100644
> --- a/android/gatt.c
> +++ b/android/gatt.c
> @@ -350,12 +350,6 @@ static void handle_client_register(const void *buf, uint16_t len)
>  
>  	DBG("");
>  
> -	if (!cmd->uuid) {
> -		error("gatt: no uuid received");
> -		status = HAL_STATUS_FAILED;
> -		goto failed;
> -	}
> -
>  	if (queue_find(gatt_clients, match_client_by_uuid, &cmd->uuid)) {
>  		error("gatt: client uuid is already on list");
>  		status = HAL_STATUS_FAILED;
> 

All patches pushed (with some fixes applied), thanks.

-- 
Best regards, 
Szymon Janc

      parent reply	other threads:[~2014-04-01 13:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-01 12:54 [PATCH v2 1/3] android/gatt: Remove redundant hal cmd check Grzegorz Kolodziejczyk
2014-04-01 12:54 ` [PATCH v2 2/3] android/gatt: Handle register gatt server command Grzegorz Kolodziejczyk
2014-04-01 12:54 ` [PATCH v2 3/3] android/gatt: Handle unregister " Grzegorz Kolodziejczyk
2014-04-01 13:56 ` Szymon Janc [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26858286.n3DPGo1T2v@uw000953 \
    --to=szymon.janc@tieto.com \
    --cc=grzegorz.kolodziejczyk@tieto.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox