Linux bluetooth development
 help / color / mirror / Atom feed
From: Szymon Janc <szymon.janc@tieto.com>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/6] android/client: Support new API for Audio HAL
Date: Wed, 05 Nov 2014 21:52:05 +0100	[thread overview]
Message-ID: <2698840.v3KCzvQ2At@leonov> (raw)
In-Reply-To: <1415191313-12810-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>

Hi Andrei,

On Wednesday 05 of November 2014 14:41:48 Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> 
> Add support for new parameter in open_output_stream().
> ---
>  android/client/if-audio.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/android/client/if-audio.c b/android/client/if-audio.c
> index f3f87fb..65e2f2f 100644
> --- a/android/client/if-audio.c
> +++ b/android/client/if-audio.c
> @@ -60,7 +60,14 @@ SINTMAP(audio_channel_mask_t, -1,
> "(AUDIO_CHANNEL_INVALID)") DELEMENT(AUDIO_CHANNEL_OUT_MONO),
>  	DELEMENT(AUDIO_CHANNEL_OUT_STEREO),
>  	DELEMENT(AUDIO_CHANNEL_OUT_QUAD),
> +#if ANDROID_VERSION < PLATFORM_VER(5, 0, 0)
>  	DELEMENT(AUDIO_CHANNEL_OUT_SURROUND),
> +#else
> +	DELEMENT(AUDIO_CHANNEL_OUT_QUAD_BACK),
> +	DELEMENT(AUDIO_CHANNEL_OUT_QUAD_SIDE),
> +	DELEMENT(AUDIO_CHANNEL_OUT_5POINT1_BACK),
> +	DELEMENT(AUDIO_CHANNEL_OUT_5POINT1_SIDE),
> +#endif
>  	DELEMENT(AUDIO_CHANNEL_OUT_5POINT1),
>  	DELEMENT(AUDIO_CHANNEL_OUT_7POINT1),
>  	DELEMENT(AUDIO_CHANNEL_OUT_ALL),
> @@ -305,12 +312,21 @@ static void open_output_stream_p(int argc, const char
> **argv) }
>  	pthread_mutex_unlock(&state_mutex);
> 
> +#if ANDROID_VERSION >= PLATFORM_VER(5, 0, 0)
> +	err = if_audio->open_output_stream(if_audio,
> +						0,
> +						AUDIO_DEVICE_OUT_ALL_A2DP,
> +						AUDIO_OUTPUT_FLAG_NONE,
> +						NULL,
> +						&stream_out, NULL);
> +#else
>  	err = if_audio->open_output_stream(if_audio,
>  						0,
>  						AUDIO_DEVICE_OUT_ALL_A2DP,
>  						AUDIO_OUTPUT_FLAG_NONE,
>  						NULL,
>  						&stream_out);
> +#endif
>  	if (err < 0) {
>  		haltest_error("open output stream returned %d\n", err);
>  		return;

All patches in this set are now applied, thanks.

-- 
BR
Szymon Janc

      parent reply	other threads:[~2014-11-05 20:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-05 12:41 [PATCH 1/6] android/client: Support new API for Audio HAL Andrei Emeltchenko
2014-11-05 12:41 ` [PATCH 2/6] android/client: Support new API for SCO HAL Andrei Emeltchenko
2014-11-05 12:41 ` [PATCH 3/6] android/client: Add support for new Android API for PAN HAL Andrei Emeltchenko
2014-11-05 12:41 ` [PATCH 4/6] android/client: Add support for new API for gatt scan() Andrei Emeltchenko
2014-11-05 12:41 ` [PATCH 5/6] android/client: Add support for new API for gatt connect() Andrei Emeltchenko
2014-11-05 12:41 ` [PATCH 6/6] android/client: Add support for new API for gatt server connect() Andrei Emeltchenko
2014-11-05 20:52 ` Szymon Janc [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2698840.v3KCzvQ2At@leonov \
    --to=szymon.janc@tieto.com \
    --cc=Andrei.Emeltchenko.news@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox