obexd-0.21: configure doesn't work as expected

obexd-0.21: configure doesn't work as expected

[Pacho Ramos]

[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]

Hello all!

The problem we are suffering downstream is the following:
http://bugs.gentoo.org/show_bug.cgi?id=305063#c5

In summary, the same files are being *installed* with
--with-phonebook=ebook and --with-phonebook=dummy (in both cases,
phonebook files are not being installed at all). A
$PREFIX/lib/obex/plugins directory is created but nothing is installed
on it.

Another problem is that, when passing --without-phonebook to configure,
build fails with:
$ make
make --no-print-directory all-am
  CC     gdbus/mainloop.o
  CC     gdbus/object.o
  CC     gdbus/watch.o
  CC     plugins/filesystem.o
  CC     plugins/opp.o
  CC     plugins/ftp.o
  CC     plugins/pbap.o
  CC     plugins/syncevolution.o
  CC     src/main.o
  GEN    src/builtin.h
  CC     src/plugin.o
  CC     src/logging.o
  CC     src/btio.o
  CC     src/manager.o
  CC     src/obex.o
  CC     src/bluetooth.o
  CC     src/mimetype.o
  CC     src/service.o
make[1]: *** No rule to make target `plugins/phonebook-no.c', needed by
`plugins/phonebook.c'.  Stop.
make: *** [all] Error 2


Thanks a lot for your help :-)

[-- Attachment #2: Esta parte del mensaje está firmada digitalmente --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: obexd-0.21: configure doesn't work as expected

[Vinicius Gomes]

Hi Pacho,

2010/2/19 Pacho Ramos <pacho@condmat1.ciencias.uniovi.es>:
> Hello all!
>
> The problem we are suffering downstream is the following:
> http://bugs.gentoo.org/show_bug.cgi?id=305063#c5
>
> In summary, the same files are being *installed* with
> --with-phonebook=ebook and --with-phonebook=dummy (in both cases,
> phonebook files are not being installed at all). A
> $PREFIX/lib/obex/plugins directory is created but nothing is installed
> on it.
>

This is not a bug, it is by design, the phonebook driver is a built-in
module. In fact, all the plugins
we have currently are built-in. That's why nothing gets installed in
the plugins folder.

> Another problem is that, when passing --without-phonebook to configure,
> build fails with:
> $ make
> make --no-print-directory all-am
>  CC     gdbus/mainloop.o
>  CC     gdbus/object.o
>  CC     gdbus/watch.o
>  CC     plugins/filesystem.o
>  CC     plugins/opp.o
>  CC     plugins/ftp.o
>  CC     plugins/pbap.o
>  CC     plugins/syncevolution.o
>  CC     src/main.o
>  GEN    src/builtin.h
>  CC     src/plugin.o
>  CC     src/logging.o
>  CC     src/btio.o
>  CC     src/manager.o
>  CC     src/obex.o
>  CC     src/bluetooth.o
>  CC     src/mimetype.o
>  CC     src/service.o
> make[1]: *** No rule to make target `plugins/phonebook-no.c', needed by
> `plugins/phonebook.c'.  Stop.
> make: *** [all] Error 2
>

Thanks for the report, this is a bug. There's a patch for it in my
development tree. Waiting for review.

But before the next release happens, disabling a plugin is equivalent
to setting its value to dummy, i.e.
--without-phonebook (if it worked ;-) would be the same as
--with-phonebook=dummy.

>
> Thanks a lot for your help :-)
>


Cheers,
-- 
Vinicius Gomes
INdT - Instituto Nokia de Tecnologia

Re: obexd-0.21: configure doesn't work as expected

[Pacho Ramos]

[-- Attachment #1: Type: text/plain, Size: 1037 bytes --]

El vie, 19-02-2010 a las 12:01 -0300, Vinicius Gomes escribió:
> > In summary, the same files are being *installed* with
> > --with-phonebook=ebook and --with-phonebook=dummy (in both cases,
> > phonebook files are not being installed at all). A
> > $PREFIX/lib/obex/plugins directory is created but nothing is installed
> > on it.
> >
> 
> This is not a bug, it is by design, the phonebook driver is a built-in
> module. In fact, all the plugins
> we have currently are built-in. That's why nothing gets installed in
> the plugins folder.

Ah, then, why is plugins folder being created even if nothing will be
installed in it?

> Thanks for the report, this is a bug. There's a patch for it in my
> development tree. Waiting for review.
> 
> But before the next release happens, disabling a plugin is equivalent
> to setting its value to dummy, i.e.
> --without-phonebook (if it worked ;-) would be the same as
> --with-phonebook=dummy.
> 

Great, where could I see your development tree?

Thanks a lot :-)

[-- Attachment #2: Esta parte del mensaje está firmada digitalmente --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: obexd-0.21: configure doesn't work as expected

[Vinicius Gomes]

Hi Pacho,

2010/2/19 Pacho Ramos <pacho@condmat1.ciencias.uniovi.es>:
> Ah, then, why is plugins folder being created even if nothing will be
> installed in it?
>

Nothing is installed right now. But it doesn't mean that nothing will
ever be ;-)

And if you want to have a custom plugin for some application, you just write
it and install it there, no need to mess with core obexd.

>> Thanks for the report, this is a bug. There's a patch for it in my
>> development tree. Waiting for review.
>>
>> But before the next release happens, disabling a plugin is equivalent
>> to setting its value to dummy, i.e.
>> --without-phonebook (if it worked ;-) would be the same as
>> --with-phonebook=dummy.
>>
>
> Great, where could I see your development tree?
>

Sure. Forgot the link, here it is:
http://git.infradead.org/users/vcgomes/obexd.git (devel branch)

> Thanks a lot :-)
>


Cheers,
-- 
Vinicius Gomes
INdT - Instituto Nokia de Tecnologia

Re: obexd-0.21: configure doesn't work as expected

[Pacho Ramos]

[-- Attachment #1: Type: text/plain, Size: 1051 bytes --]

El vie, 19-02-2010 a las 14:24 -0300, Vinicius Gomes escribió:
> 
> 2010/2/19 Pacho Ramos <pacho@condmat1.ciencias.uniovi.es>:
> > Ah, then, why is plugins folder being created even if nothing will be
> > installed in it?
> >
> 
> Nothing is installed right now. But it doesn't mean that nothing will
> ever be ;-)
>
> And if you want to have a custom plugin for some application, you just write
> it and install it there, no need to mess with core obexd.
> 

True, silly me! 

> >> Thanks for the report, this is a bug. There's a patch for it in my
> >> development tree. Waiting for review.
> >>
> >> But before the next release happens, disabling a plugin is equivalent
> >> to setting its value to dummy, i.e.
> >> --without-phonebook (if it worked ;-) would be the same as
> >> --with-phonebook=dummy.
> >>
> >
> > Great, where could I see your development tree?
> >
> 
> Sure. Forgot the link, here it is:
> http://git.infradead.org/users/vcgomes/obexd.git (devel branch)
> 
Great :-D

Thanks and best regards

[-- Attachment #2: Esta parte del mensaje está firmada digitalmente --]
[-- Type: application/pgp-signature, Size: 198 bytes --]