From: "Sven Peter" <sven@svenpeter.dev>
To: "Yang Yingliang" <yangyingliang@huawei.com>,
linux-bluetooth@vger.kernel.org
Cc: luiz.von.dentz@intel.com
Subject: Re: [PATCH -next] Bluetooth: hci_bcm4377: Fix missing pci_disable_device() on error in bcm4377_probe()
Date: Sat, 12 Nov 2022 11:28:10 +0100 [thread overview]
Message-ID: <2d282d22-20be-4e27-b3ef-3048779f939b@app.fastmail.com> (raw)
In-Reply-To: <20221112090437.3591380-1-yangyingliang@huawei.com>
Hi,
On Sat, Nov 12, 2022, at 10:04, Yang Yingliang wrote:
> pci_disable_device() need be called while module exiting, switch to use
> pcim_enable(), pci_disable_device() will be called in pcim_release()
> after probe() failure.
>
> Fixes: ab80b2cec05f ("Bluetooth: hci_bcm4377: Add new driver for
> BCM4377 PCIe boards")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
Good catch, thanks!
Reviewed-by: Sven Peter <sven@svenpeter.dev>
Best,
Sven
next prev parent reply other threads:[~2022-11-12 10:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-12 9:04 [PATCH -next] Bluetooth: hci_bcm4377: Fix missing pci_disable_device() on error in bcm4377_probe() Yang Yingliang
2022-11-12 9:47 ` [-next] " bluez.test.bot
2022-11-12 10:28 ` Sven Peter [this message]
2022-11-14 22:10 ` [PATCH -next] " patchwork-bot+bluetooth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d282d22-20be-4e27-b3ef-3048779f939b@app.fastmail.com \
--to=sven@svenpeter.dev \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.von.dentz@intel.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox