linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: Nick Pelly <npelly@google.com>
Cc: Marcel Holtmann <marcel@holtmann.org>, linux-bluetooth@vger.kernel.org
Subject: Re: bug? kernel does not send HCI Create Connection Cancel Command on shutdown() or close() of a connecting rfcomm socket
Date: Mon, 13 Jul 2009 18:27:51 -0300	[thread overview]
Message-ID: <2d5a2c100907131427x18f26f82g405a781cd8670b88@mail.gmail.com> (raw)
In-Reply-To: <35c90d960907130846v2320de88pd6f34b8aabfdbb9e@mail.gmail.com>

Hi Nick,

On Mon, Jul 13, 2009 at 12:46 PM, Nick Pelly<npelly@google.com> wrote:
> Any comments on this patch?
>
> It works for me, but my understanding of the RFCOMM state machine is naiv=
e.
>

iirc BT_CONFIG(PN frame) means the DLC is being configured than we got
into connecting phase (BT_CONNECT) and send SABM frame. Only when
receiving UA frame DLC is consider connected (BT_CONNECTED), so your
patch seems good by assuming that we don't need to send a DISC for a
DLC not connected. But there is still a good use for it to cancel the
DLC connection attempt, so perhaps a better alternative would be to
use a much shorter timeout in those cases.


--=20
Luiz Augusto von Dentz
Engenheiro de Computa=E7=E3o

  reply	other threads:[~2009-07-13 21:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-20  1:20 bug? kernel does not send HCI Create Connection Cancel Command on shutdown() or close() of a connecting rfcomm socket Nick Pelly
2009-05-20  2:49 ` Marcel Holtmann
2009-05-20 21:57   ` Nick Pelly
2009-07-06 18:55     ` Nick Pelly
2009-07-06 23:31       ` Marcel Holtmann
2009-07-09 19:37       ` Nick Pelly
2009-07-13 15:46         ` Nick Pelly
2009-07-13 21:27           ` Luiz Augusto von Dentz [this message]
2009-07-14 16:15             ` Nick Pelly
2009-07-15 22:11               ` Nick Pelly
2009-08-06 18:03                 ` Nick Pelly
2010-02-03  1:54                   ` Nick Pelly
2010-02-03  1:56                   ` Nick Pelly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2d5a2c100907131427x18f26f82g405a781cd8670b88@mail.gmail.com \
    --to=luiz.dentz@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=npelly@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).