linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: Claudio Takahasi <claudio.takahasi@openbossa.org>
Cc: Johan Hedberg <johan.hedberg@nokia.com>,
	luiz.dentz-von@nokia.com,
	BlueZ development <linux-bluetooth@vger.kernel.org>
Subject: Re: bluetoothd bug
Date: Tue, 26 Jan 2010 13:09:16 +0200	[thread overview]
Message-ID: <2d5a2c101001260309h4464805eg3e52ace6dd28f677@mail.gmail.com> (raw)
In-Reply-To: <f9d4bd31001251014w1caaa753v39254c3031f5db0e@mail.gmail.com>

Hi Claudio,

On Mon, Jan 25, 2010 at 8:14 PM, Claudio Takahasi
<claudio.takahasi@openbossa.org> wrote:
> Hi Johan/Luiz,
>
> I found an error "invalid read". The pastebin log shows a PBAP
> connection in the RFCOMM channel 15. See line 195 of the first log,
> when the connection is refused the "temporary" device is being
> removed, however it seems that the "reverse" SDP query still active.
> PTS is establishing RFCOMM connection before "Encrypt Change" event,
> but this wrong procedure should not "harm" bluetoothd. In some cases I
> noticed segmentation fault, probably due this error.
>
> http://pastebin.com/m308f85ef
> http://pastebin.com/m2d80dd71

Does this fix the problem:

diff --git a/src/device.c b/src/device.c
index a2730ab..dfdacd8 100644
--- a/src/device.c
+++ b/src/device.c
@@ -239,6 +239,9 @@ static void device_free(gpointer user_data)
        if (device->disconn_timer)
                g_source_remove(device->disconn_timer);

+       if (device->discov_timer)
+               g_source_remove(device->discov_timer);
+
        debug("device_free(%p)", device);

        g_free(device->authr);


-- 
Luiz Augusto von Dentz
Engenheiro de Computação

  reply	other threads:[~2010-01-26 11:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-25 18:14 bluetoothd bug Claudio Takahasi
2010-01-26 11:09 ` Luiz Augusto von Dentz [this message]
2010-01-26 18:33   ` Claudio Takahasi
2010-01-27  8:21     ` Luiz Augusto von Dentz
2010-01-27  8:28       ` Johan Hedberg
2010-01-27  8:43       ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2d5a2c101001260309h4464805eg3e52ace6dd28f677@mail.gmail.com \
    --to=luiz.dentz@gmail.com \
    --cc=claudio.takahasi@openbossa.org \
    --cc=johan.hedberg@nokia.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz-von@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).