linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH] Fix bug on ftp plugin when mimetype exists but is unknown
Date: Tue, 16 Feb 2010 16:37:06 +0200	[thread overview]
Message-ID: <2d5a2c101002160637k59f9cb0fx963d3b489ee37df3@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

Hi,

The code was returning FALSE (0) when it should return a posix error thus
causing a unkown mimetype to not be handle by mimetype drivers as it
should.

ps: obexd patch

Regards,

-- 
Luiz Augusto von Dentz
Computer Engineer

[-- Attachment #2: 0001-Fix-bug-on-ftp-plugin-when-mimetype-exists-but-is-un.patch --]
[-- Type: text/x-patch, Size: 893 bytes --]

From 74a67587e3f30788c714582cce8f2f790465261e Mon Sep 17 00:00:00 2001
From: Luiz Augusto Von Dentz <luiz.dentz-von@nokia.com>
Date: Mon, 15 Feb 2010 13:33:06 +0200
Subject: [PATCH] Fix bug on ftp plugin when mimetype exists but is unknown

The code was returning FALSE (0) when it should return a posix error thus
causing a unkown mimetype to not be handle by mimetype drivers as it
should.
---
 plugins/ftp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/plugins/ftp.c b/plugins/ftp.c
index f15597e..e0a3b97 100644
--- a/plugins/ftp.c
+++ b/plugins/ftp.c
@@ -155,7 +155,7 @@ static gint get_by_type(struct obex_session *os, gchar *type, size_t *size)
 	if (g_str_equal(type, LST_TYPE))
 		return os_prepare_get(os, os->current_folder, size);
 
-	return FALSE;
+	return -ENOENT;
 }
 
 static gint ftp_prepare_get(struct obex_session *os, gchar *file,
-- 
1.6.3.3


             reply	other threads:[~2010-02-16 14:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-16 14:37 Luiz Augusto von Dentz [this message]
2010-02-16 15:33 ` [PATCH] Fix bug on ftp plugin when mimetype exists but is unknown Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2d5a2c101002160637k59f9cb0fx963d3b489ee37df3@mail.gmail.com \
    --to=luiz.dentz@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).