From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Fix signal watch when a service name is given
Date: Tue, 16 Feb 2010 17:58:04 +0200 [thread overview]
Message-ID: <2d5a2c101002160758k131bd0f1y3477958780d11a02@mail.gmail.com> (raw)
In-Reply-To: <1266334628.8849.5.camel@localhost.localdomain>
Hi Marcel,
On Tue, Feb 16, 2010 at 5:37 PM, Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Luiz,
>
>> > This should fix g_dbus_add_signal_watch when a service like org.bluez is given.
>>
>>
>> Updating since the last one was broken.
>
> I also think that in check_service() we actually have a missing call to
> dbus_pending_unref(). That would cause a memory leak.
There is a call to dbus_pending_call_unref on check_service after
dbus_pending_call_set_notify, which I took a look and seems correct
but we have another problem there since we never cancel the pending
call if the filter is unregister. Anyway there is a leak on
service_reply where I don't call dbus_message_unref, so I will come up
with another update soon.
--
Luiz Augusto von Dentz
Computer Engineer
next prev parent reply other threads:[~2010-02-16 15:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-16 14:59 [PATCH] Fix signal watch when a service name is given Luiz Augusto von Dentz
2010-02-16 15:15 ` Luiz Augusto von Dentz
2010-02-16 15:37 ` Marcel Holtmann
2010-02-16 15:58 ` Luiz Augusto von Dentz [this message]
2010-02-16 16:25 ` Luiz Augusto von Dentz
2010-02-17 0:34 ` Vinicius Gomes
2010-02-17 9:06 ` Luiz Augusto von Dentz
2010-02-17 10:00 ` Marcel Holtmann
2010-02-17 16:08 ` Luiz Augusto von Dentz
2010-02-21 20:41 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d5a2c101002160758k131bd0f1y3477958780d11a02@mail.gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).