Re: [PATCH v2 2/2] Emit Adapter.PropertyChanged when UUIDs change

[Luiz Augusto von Dentz <luiz.dentz@gmail.com>]

Hi,

On Mon, Mar 29, 2010 at 11:29 AM, Marcel Holtmann <marcel@holtmann.org> wro=
te:
> Hi Johan,
>
>> > Emitting Adapter.PropertyChanged signal when UUIDs change. D-Bus messa=
ge
>> > to inform that adapter properties changed.
>> > ---
>> > =A0src/adapter.c =A0 =A0 =A0 | =A0 75 ++++++++++++++++++++++++++++++++=
++++++++++++------
>> > =A0src/adapter.h =A0 =A0 =A0 | =A0 =A01 +
>> > =A0src/sdpd-database.c | =A0 =A03 ++
>> > =A03 files changed, 70 insertions(+), 9 deletions(-)
>>
>> Thanks for the patches. In principle they look good, but I haven't
>> applied them yet due to one thing that looks a bit strange: both the SDP
>> server record UUID (0x1000) as well as the public browse group UUID
>> (0x1001) always show up in the UUIDs list. I wonder if there'd be any
>> clean way to avoid getting them into the list. Marcel, do you have any
>> idea about this or is it even a problem that these UUIDs are always in
>> the list?
>
> these UUIDs are always in the server, but not in the public browse group
> and we skip them on purpose. The only reason why they are always present
> is that the specification requires it.

IMO, it should be the same list as we export in extended inquiry
response, so perhaps we could use the data from
create_ext_inquiry_response which already filter those away. Perhaps
some refactoring could also be done since this code seems to be called
multiple times in case of new services because it also changes class
which then triggers create_ext_inquiry_response again.


--=20
Luiz Augusto von Dentz
Computer Engineer