Linux bluetooth development
 help / color / mirror / Atom feed
From: Tedd Ho-Jeong An <tedd.an@intel.com>
To: Anderson Lizardo <anderson.lizardo@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org, marcel@holtmann.org,
	johan.hedberg@intel.com, don.fry@intel.com
Subject: Re: [PATCH] Bluetooth: Add support for Intel Bluetooth device [8087:07dc]
Date: Fri, 12 Apr 2013 10:33:47 -0700	[thread overview]
Message-ID: <3003415.FJhpspW2hz@tedd-ubuntu> (raw)
In-Reply-To: <CAJdJm_NmHWTGcBCDt+wFtR-ARPqxi5bWR1fSQSdJHvEs2Vo61w@mail.gmail.com>

Hi Anderson.

Thanks for the comments.
I didn't know that I needed to run with "strict" option.

I will fix it and send new one.

Regards.

Tedd


On Friday, April 12, 2013 06:44:19 AM Anderson Lizardo wrote:
> Hi Tedd,
> 
> On Thu, Apr 11, 2013 at 7:31 PM, Tedd Ho-Jeong An <tedd.an@intel.com> wrote:
> > From: Tedd Ho-Jeong An <tedd.an@intel.com>
> >
> > This patch adds support for Intel Bluetooth device by adding
> > btusb_setup_intel() routine that update the device with ROM patch.
> 
> You might want to run "./scripts/checkpatch.pl --strict" on your
> patch, which will report various alignment issues. These issues were
> very criticized on the past, therefore you may want to fix them.
> 
> There is a line exceeding the 80-column limit as well, which should be
> easy to fix.
> 
> Best Regards,
> 


      reply	other threads:[~2013-04-12 17:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-11 23:31 [PATCH] Bluetooth: Add support for Intel Bluetooth device [8087:07dc] Tedd Ho-Jeong An
2013-04-12 10:44 ` Anderson Lizardo
2013-04-12 17:33   ` Tedd Ho-Jeong An [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3003415.FJhpspW2hz@tedd-ubuntu \
    --to=tedd.an@intel.com \
    --cc=anderson.lizardo@openbossa.org \
    --cc=don.fry@intel.com \
    --cc=johan.hedberg@intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox