From: Szymon Janc <szymon.janc@gmail.com>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 2/3] android/avdtp: Retry send on EAGAIN as well
Date: Fri, 24 Jan 2014 23:16:39 +0100 [thread overview]
Message-ID: <3119819.bMHWn5I4f0@athlon> (raw)
In-Reply-To: <1390575403-30860-2-git-send-email-Andrei.Emeltchenko.news@gmail.com>
Hi Andrei,
On Friday 24 January 2014 16:56:42 Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> ---
> android/avdtp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/android/avdtp.c b/android/avdtp.c
> index 5da1206..1055bc1 100644
> --- a/android/avdtp.c
> +++ b/android/avdtp.c
> @@ -444,7 +444,7 @@ static gboolean try_send(int sk, void *data, size_t len)
>
> do {
> err = send(sk, data, len, 0);
> - } while (err < 0 && errno == EINTR);
> + } while (err < 0 && (errno == EINTR || errno == EAGAIN));
>
This makes try_send() blocking, if this is ok then at least some explanation
in commit message would be welcome.
> if (err < 0) {
> error("send: %s (%d)", strerror(errno), errno);
--
Szymon K. Janc
szymon.janc@gmail.com
next prev parent reply other threads:[~2014-01-24 22:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-24 14:56 [PATCH 1/3] bnep: Calculate ifindex after NULL check Andrei Emeltchenko
2014-01-24 14:56 ` [PATCH 2/3] android/avdtp: Retry send on EAGAIN as well Andrei Emeltchenko
2014-01-24 22:16 ` Szymon Janc [this message]
2014-01-26 4:29 ` Luiz Augusto von Dentz
2014-01-24 14:56 ` [PATCH 3/3] avctp: Fix unchecked return value Andrei Emeltchenko
2014-01-24 15:00 ` Anderson Lizardo
2014-01-27 15:59 ` [PATCHv2] " Andrei Emeltchenko
2014-01-27 18:41 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3119819.bMHWn5I4f0@athlon \
--to=szymon.janc@gmail.com \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox