From: Szymon Janc <szymon.janc@tieto.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: "linux-bluetooth@vger.kernel.org development"
<linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH 4/5] android/hal-bluetooth: Add support for device service record property
Date: Fri, 20 Dec 2013 14:38:18 +0100 [thread overview]
Message-ID: <3121104.trYEc2PX04@uw000953> (raw)
In-Reply-To: <D18535D5-351D-4C61-9D7E-6486E8558859@holtmann.org>
Hi Marcel,
> Hi Szymon,
>
> > This allows to correctly handle device service record property.
> > ---
> > android/hal-bluetooth.c | 15 +++++++++++++++
> > android/hal-msg.h | 7 +++++++
> > 2 files changed, 22 insertions(+)
> >
> > diff --git a/android/hal-bluetooth.c b/android/hal-bluetooth.c
> > index d0c1c01..4ef2ebe 100644
> > --- a/android/hal-bluetooth.c
> > +++ b/android/hal-bluetooth.c
> > @@ -166,6 +166,21 @@ static void device_props_to_hal(bt_property_t *send_props,
> > break;
> > #endif
> > case HAL_PROP_DEVICE_SERVICE_REC:
> > + {
> > + static bt_service_record_t e;
>
> why static here. Since we are essentially multi-threaded, this can be dangerous.
This is executed only in notification thread context, so not multi-threading here.
(yes, commit message could be better)
--
BR
Szymon Janc
next prev parent reply other threads:[~2013-12-20 13:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 10:25 [PATCH 0/5] android: Update HAL to Android 4.4 API Szymon Janc
2013-12-20 10:25 ` [PATCH 1/5] android/hal-bluetooth: Add support for sending LE_TEST_MODE command Szymon Janc
2013-12-20 11:57 ` Anderson Lizardo
2013-12-20 10:25 ` [PATCH 2/5] android/hal-bluetooth: Add support for enabling HCI snoop dump Szymon Janc
2013-12-20 10:25 ` [PATCH 3/5] android/hal-bluetooth: Add support for remote version info property Szymon Janc
2013-12-20 12:07 ` Anderson Lizardo
2013-12-20 10:25 ` [PATCH 4/5] android/hal-bluetooth: Add support for device service record property Szymon Janc
2013-12-20 13:18 ` Marcel Holtmann
2013-12-20 13:38 ` Szymon Janc [this message]
2013-12-20 13:43 ` Marcel Holtmann
2013-12-20 14:00 ` Szymon Janc
2013-12-20 10:25 ` [PATCH 5/5] android/bluetooth: Add stubs for missing commands Szymon Janc
2013-12-20 10:58 ` [PATCH 0/5] android: Update HAL to Android 4.4 API Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3121104.trYEc2PX04@uw000953 \
--to=szymon.janc@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox