From: Szymon Janc <szymon.janc@tieto.com>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] android/gatt: Remove dead code
Date: Wed, 25 Jun 2014 08:18:02 -0700 (PDT) [thread overview]
Message-ID: <3179188.quvouCAdva@uw000953> (raw)
In-Reply-To: <1403173701-23206-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>
Hi Andrei,
On Thursday 19 of June 2014 13:28:21 Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> The code apparently left after wrong rebase as it duplicates code
> several lines above.
> ---
> android/gatt.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/android/gatt.c b/android/gatt.c
> index 24884e9..5007817 100644
> --- a/android/gatt.c
> +++ b/android/gatt.c
> @@ -5310,11 +5310,6 @@ static uint8_t find_info_handle(const uint8_t *cmd, uint16_t cmd_len,
>
> }
>
> - if (!adl) {
> - queue_destroy(q, NULL);
> - return ATT_ECODE_INSUFF_RESOURCES;
> - }
> -
> len = enc_find_info_resp(ATT_FIND_INFO_RESP_FMT_16BIT, adl, rsp,
> rsp_size);
> if (!len)
>
Patch applied, thanks.
--
Best regards,
Szymon Janc
prev parent reply other threads:[~2014-06-25 15:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 10:28 [PATCH] android/gatt: Remove dead code Andrei Emeltchenko
2014-06-25 15:18 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3179188.quvouCAdva@uw000953 \
--to=szymon.janc@tieto.com \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox