* [PATCH] android/gatt: Remove dead code
@ 2014-06-19 10:28 Andrei Emeltchenko
2014-06-25 15:18 ` Szymon Janc
0 siblings, 1 reply; 2+ messages in thread
From: Andrei Emeltchenko @ 2014-06-19 10:28 UTC (permalink / raw)
To: linux-bluetooth
From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
The code apparently left after wrong rebase as it duplicates code
several lines above.
---
android/gatt.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/android/gatt.c b/android/gatt.c
index 24884e9..5007817 100644
--- a/android/gatt.c
+++ b/android/gatt.c
@@ -5310,11 +5310,6 @@ static uint8_t find_info_handle(const uint8_t *cmd, uint16_t cmd_len,
}
- if (!adl) {
- queue_destroy(q, NULL);
- return ATT_ECODE_INSUFF_RESOURCES;
- }
-
len = enc_find_info_resp(ATT_FIND_INFO_RESP_FMT_16BIT, adl, rsp,
rsp_size);
if (!len)
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] android/gatt: Remove dead code
2014-06-19 10:28 [PATCH] android/gatt: Remove dead code Andrei Emeltchenko
@ 2014-06-25 15:18 ` Szymon Janc
0 siblings, 0 replies; 2+ messages in thread
From: Szymon Janc @ 2014-06-25 15:18 UTC (permalink / raw)
To: Andrei Emeltchenko; +Cc: linux-bluetooth
Hi Andrei,
On Thursday 19 of June 2014 13:28:21 Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> The code apparently left after wrong rebase as it duplicates code
> several lines above.
> ---
> android/gatt.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/android/gatt.c b/android/gatt.c
> index 24884e9..5007817 100644
> --- a/android/gatt.c
> +++ b/android/gatt.c
> @@ -5310,11 +5310,6 @@ static uint8_t find_info_handle(const uint8_t *cmd, uint16_t cmd_len,
>
> }
>
> - if (!adl) {
> - queue_destroy(q, NULL);
> - return ATT_ECODE_INSUFF_RESOURCES;
> - }
> -
> len = enc_find_info_resp(ATT_FIND_INFO_RESP_FMT_16BIT, adl, rsp,
> rsp_size);
> if (!len)
>
Patch applied, thanks.
--
Best regards,
Szymon Janc
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-25 15:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-19 10:28 [PATCH] android/gatt: Remove dead code Andrei Emeltchenko
2014-06-25 15:18 ` Szymon Janc
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).