From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@inria.fr>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Marcel Holtmann <marcel@holtmann.org>,
linux-bluetooth@vger.kernel.org, kernel-janitors@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: Bluetooth: qca: Use common error handling code in two functions
Date: Sun, 5 May 2024 12:30:54 +0200 [thread overview]
Message-ID: <31f78b18-0caa-45c0-af84-c95d525a13dc@web.de> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2405051105000.3397@hadrien>
>> Add a jump target so that the setting of an error code can be better reused
>> at the end of these function implementations.
…
> This reduces readability, and backwards jumps are rarely desirable.
Would you like to support any other design approaches better for
the reduction of questionable source code duplication?
Regards,
Markus
next prev parent reply other threads:[~2024-05-05 10:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-05 8:39 [PATCH] Bluetooth: qca: Use common error handling code in two functions Markus Elfring
2024-05-05 9:06 ` Julia Lawall
2024-05-05 10:30 ` Markus Elfring [this message]
2024-05-05 10:37 ` Julia Lawall
2024-05-05 9:33 ` bluez.test.bot
2024-05-06 5:35 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31f78b18-0caa-45c0-af84-c95d525a13dc@web.de \
--to=markus.elfring@web.de \
--cc=julia.lawall@inria.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox