From: Szymon Janc <szymon.janc@tieto.com>
To: Marcin Kraglak <marcin.kraglak@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCHv6 00/14] Included service discovery
Date: Thu, 23 Oct 2014 14:59:20 +0200 [thread overview]
Message-ID: <3217191.obB9pmHZrM@uw000953> (raw)
In-Reply-To: <1414059337-12040-1-git-send-email-marcin.kraglak@tieto.com>
Hi Marcin,
On Thursday 23 of October 2014 12:15:23 Marcin Kraglak wrote:
> v3:
> In this version after primary service discovery,
> secondary services are discovered. Next included
> services are resolved. With this approach we
> don't have recursively search for included service,
> like it was TODO in previous proposal.
> There is also small coding style fix suggested by Arman.
>
> v4:
> If no secondary services found, continue include services search (fixed
> in gatt-client.c).
> Fixed wrong debug logs (primary->secondary).
> Fixed searching descriptors
>
> v5:
> Ignore Unsupported Group Type Error in response to secondary service
> discovery and continue included services discovery.
>
> v6
> * Added comments to specific calculations and numbers.
> * Fixed goto labels as suggested by Szymon
> * Changed printing type of service.
> * Typo fixes pointed by Szymon
>
> Marcin Kraglak (14):
> shared/gatt: Add discover_secondary_services()
> shared/gatt: Add initial implementation of discover_included_services
> shared/gatt: Discover included services 128 bit UUIDS
> shared/gatt: Add extra check in characteristic iterator
> shared/gatt: Add included service iterator
> shared/gatt: Add function bt_gatt_result_included_count()
> shared/gatt: Remove not needed function parameter
> shared/gatt: Distinguish Primary from Secondary services
> tools/btgatt-client: Print type of service
> shared/gatt: Discover secondary services
> shared/gatt: Discover included services
> shared/gatt: Add gatt-client include service iterator
> tools/btgatt-client: Print found include services
> shared/gatt: Fix searching descriptors
>
> src/shared/gatt-client.c | 252 +++++++++++++++++++++++--
> src/shared/gatt-client.h | 18 ++
> src/shared/gatt-helpers.c | 462 ++++++++++++++++++++++++++++++++++++++++++++--
> src/shared/gatt-helpers.h | 10 +-
> tools/btgatt-client.c | 20 +-
> 5 files changed, 725 insertions(+), 37 deletions(-)
>
All patches in this set have been applied. Thanks a lot.
--
Best regards,
Szymon Janc
prev parent reply other threads:[~2014-10-23 12:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 10:15 [PATCHv6 00/14] Included service discovery Marcin Kraglak
2014-10-23 10:15 ` [PATCHv6 01/14] shared/gatt: Add discover_secondary_services() Marcin Kraglak
2014-10-23 10:15 ` [PATCHv6 02/14] shared/gatt: Add initial implementation of discover_included_services Marcin Kraglak
2014-10-23 10:15 ` [PATCHv6 03/14] shared/gatt: Discover included services 128 bit UUIDS Marcin Kraglak
2014-10-23 10:15 ` [PATCHv6 04/14] shared/gatt: Add extra check in characteristic iterator Marcin Kraglak
2014-10-23 10:15 ` [PATCHv6 05/14] shared/gatt: Add included service iterator Marcin Kraglak
2014-10-23 10:15 ` [PATCHv6 06/14] shared/gatt: Add function bt_gatt_result_included_count() Marcin Kraglak
2014-10-23 10:15 ` [PATCHv6 07/14] shared/gatt: Remove not needed function parameter Marcin Kraglak
2014-10-23 10:15 ` [PATCHv6 08/14] shared/gatt: Distinguish Primary from Secondary services Marcin Kraglak
2014-10-23 10:15 ` [PATCHv6 09/14] tools/btgatt-client: Print type of service Marcin Kraglak
2014-10-23 10:15 ` [PATCHv6 10/14] shared/gatt: Discover secondary services Marcin Kraglak
2014-10-23 12:35 ` Marcin Kraglak
2014-10-23 12:36 ` Marcin Kraglak
2014-10-23 10:15 ` [PATCHv6 11/14] shared/gatt: Discover included services Marcin Kraglak
2014-10-23 10:15 ` [PATCHv6 12/14] shared/gatt: Add gatt-client include service iterator Marcin Kraglak
2014-10-23 10:15 ` [PATCHv6 13/14] tools/btgatt-client: Print found include services Marcin Kraglak
2014-10-23 10:15 ` [PATCHv6 14/14] shared/gatt: Fix searching descriptors Marcin Kraglak
2014-10-23 12:59 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3217191.obB9pmHZrM@uw000953 \
--to=szymon.janc@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcin.kraglak@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox