linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Szymon Janc <szymon.janc@tieto.com>
To: Ravi kumar Veeramally <ravikumar.veeramally@linux.intel.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/4] android/health: Fix connect channel failure case
Date: Tue, 19 Aug 2014 18:42:30 +0200	[thread overview]
Message-ID: <3374360.1SjBy6sgGZ@leonov> (raw)
In-Reply-To: <1408352822-21572-1-git-send-email-ravikumar.veeramally@linux.intel.com>

Hi Ravi,

On Monday 18 of August 2014 12:06:59 Ravi kumar Veeramally wrote:
> There is a possibilty of created channel is being added to queue,
> but on failure case it does channel free but not removed from queue.
> ---
>  android/health.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/android/health.c b/android/health.c
> index f4edc3e..f86fd26 100644
> --- a/android/health.c
> +++ b/android/health.c
> @@ -1978,6 +1978,7 @@ static void bt_health_connect_channel(const void *buf,
> uint16_t len) return;
> 
>  fail:
> +	queue_remove(channel->dev->channels, channel);
>  	free_health_channel(channel);
>  	ipc_send_rsp(hal_ipc, HAL_SERVICE_ID_HEALTH,
>  			HAL_OP_HEALTH_CONNECT_CHANNEL, HAL_STATUS_FAILED);

I've applied patches 1, 3 and 4. Thanks.

-- 
BR
Szymon Janc

      parent reply	other threads:[~2014-08-19 16:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-18  9:06 [PATCH 1/4] android/health: Fix connect channel failure case Ravi kumar Veeramally
2014-08-18  9:07 ` [PATCH 2/4] android/health: Remove mcl instance on mcl_disconnected call back Ravi kumar Veeramally
2014-08-19 16:43   ` Szymon Janc
2014-08-18  9:07 ` [PATCH 3/4] android/health: Add some information messages Ravi kumar Veeramally
2014-08-18  9:07 ` [PATCH 4/4] android/health: Simplify search_cb failure case Ravi kumar Veeramally
2014-08-19 16:42 ` Szymon Janc [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3374360.1SjBy6sgGZ@leonov \
    --to=szymon.janc@tieto.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=ravikumar.veeramally@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).