Re: duplicate L2CAP connection requests - before and after L2CAP information response

[Nick Pelly <npelly@google.com>]

Hi Marcel,

On Wed, Jan 28, 2009 at 12:12 AM, Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Nick,
>
> I think your kernel is wrongly patched. Don't cherry-pick patches that
> you don't know the impact of.

Thanks for testing,

I've narrowed it down. The rogue patch is in fact ours:

@@ -916,8 +916,8 @@ static inline void hci_conn_complete_evt(struct
hci_dev *hdev, struct sk_buff *s
                }
        }

+       hci_proto_connect_cfm(conn, ev->status);
        if (ev->status) {
-               hci_proto_connect_cfm(conn, ev->status);
                hci_conn_del(conn);
        }

This patch was motivated by a discussion in an earlier thread - see
conn->state vs conn->sk->sk_state.

Sorry for the false alarm, I was not initially suspicious of this
patch because it was not in l2cap.c.

Nick