linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nick Pelly <npelly@google.com>
To: smcoe1 <smcoe1@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] eSCO fallback to SCO on Error: Connection Failed to Complete
Date: Thu, 11 Feb 2010 13:20:19 -0800	[thread overview]
Message-ID: <35c90d961002111320n3e5626d6oca767c7facccc356@mail.gmail.com> (raw)
In-Reply-To: <9c9ad6a31002111256v1c3394d1rade3c3640ee7efb5@mail.gmail.com>

On Thu, Feb 11, 2010 at 12:56 PM, smcoe1 <smcoe1@gmail.com> wrote:
> Below is a patch necessary to pass test case TC_AG_ACS_BC_10_I on
> SIG's PTS Software
>
>
> 2007-09-20 12:08:09.471838 > HCI Event: Command Status (0x0f) plen 4
>    Setup Synchronous Connection (0x01|0x0028) status 0x00 ncmd 1
> 2007-09-20 12:08:09.479874 > HCI Event: Max Slots Change (0x1b) plen 3
>    handle 39 slots 1
> 2007-09-20 12:08:11.821730 > HCI Event: Synchronous Connect Complete
> (0x2c) plen 17
>    status 0x11 handle 39 bdaddr 00:16:93:01:01:7A type eSCO
>    Error: Unsupported Feature or Parameter Value
> 2007-09-20 12:08:11.821839 < HCI Command: Setup Synchronous Connection
> (0x01|0x0028) plen 17
>    handle 39 voice setting 0x0060
> 2007-09-20 12:08:11.824099 > HCI Event: Command Status (0x0f) plen 4
>    Setup Synchronous Connection (0x01|0x0028) status 0x00 ncmd 0
> 2007-09-20 12:08:11.832809 > HCI Event: Max Slots Change (0x1b) plen 3
>    handle 39 slots 5
> 2007-09-20 12:08:11.832840 > HCI Event: Command Status (0x0f) plen 4
>    Unknown (0x00|0x0000) status 0x00 ncmd 1
> 2007-09-20 12:08:11.841195 > HCI Event: Max Slots Change (0x1b) plen 3
>    handle 39 slots 1
> 2007-09-20 12:08:12.063088 > HCI Event: Synchronous Connect Complete
> (0x2c) plen 17
>    status 0x00 handle 38 bdaddr 00:16:93:01:01:7A type SCO
>    Air mode: CVSD
>
>
> Signed-off-by: Stephen Coe <smcoe1@gmail.com>
> ---
>  net/bluetooth/hci_event.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
> index 592da5c..715162c 100644
> --- a/net/bluetooth/hci_event.c
> +++ b/net/bluetooth/hci_event.c
> @@ -1698,6 +1698,7 @@ static inline void
> hci_sync_conn_complete_evt(struct hci_dev *hdev, struct sk_bu
>                hci_conn_add_sysfs(conn);
>                break;
>
> +       case 0x11:      /* Connection Failed to Complete */

You should probably use the real error description which is
"Unsupported Feature Or Parameter Value".

>        case 0x1c:      /* SCO interval rejected */
>        case 0x1a:      /* Unsupported Remote Feature */
>        case 0x1f:      /* Unspecified error */
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

  reply	other threads:[~2010-02-11 21:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-11 20:56 [PATCH] eSCO fallback to SCO on Error: Connection Failed to Complete smcoe1
2010-02-11 21:20 ` Nick Pelly [this message]
2010-02-12 16:06   ` smcoe1
2010-02-12 17:56     ` Marcel Holtmann
2010-02-16 15:21       ` smcoe1
2010-02-16 15:40         ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35c90d961002111320n3e5626d6oca767c7facccc356@mail.gmail.com \
    --to=npelly@google.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=smcoe1@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).