From: Nick Pelly <npelly@google.com>
To: Ville Tervo <ville.tervo@nokia.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH] Bluetooth: Allow SCO/eSCO packet type selection for outgoing SCO connections.
Date: Thu, 25 Feb 2010 17:05:03 -0800 [thread overview]
Message-ID: <35c90d961002251705j2cd95a8cjc7d10aa432a49f4@mail.gmail.com> (raw)
In-Reply-To: <4B82380A.6040204@nokia.com>
On Sun, Feb 21, 2010 at 11:53 PM, Ville Tervo <ville.tervo@nokia.com> wrote:
> Nick Pelly wrote:
>>>>
>>>> Attached is a new patch with the consistent bit logic.
>>>>
>>>> Comments?
>>>
>>> In order to keep backwards compatibility 1 should mean "don't allow this
>>> packet type" for all packets. Other wise old application with new kernel
>>> would not allow any packet types.
>>
>> The current patch achieves this backwards compatibility by assuming
>> that all packet types are allowed if the old sockaddr_sco struct is
>> used (it checks the size), or if sco_pkt_type is 0.
>
> OK. Then my concerns are gone.
As best I can tell there are no objections. We're going ahead with this patch.
http://android.git.kernel.org/?p=kernel/common.git;a=commit;h=3b077241e02041b1f03fee912896b8de1d7ac096
Nick
next prev parent reply other threads:[~2010-02-26 1:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-11 19:54 [PATCH] Bluetooth: Allow SCO/eSCO packet type selection for outgoing SCO connections Nick Pelly
2010-02-11 19:59 ` Nick Pelly
2010-02-15 21:15 ` Nick Pelly
2010-02-17 9:30 ` Ville Tervo
2010-02-17 16:49 ` Nick Pelly
2010-02-17 17:31 ` Marcel Holtmann
2010-02-18 6:49 ` Ville Tervo
2010-02-18 23:47 ` Nick Pelly
2010-02-19 8:08 ` Ville Tervo
2010-02-19 21:23 ` Nick Pelly
2010-02-22 7:53 ` Ville Tervo
2010-02-26 1:05 ` Nick Pelly [this message]
2010-02-26 9:20 ` Iain Hibbert
2010-03-19 18:48 ` smcoe1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35c90d961002251705j2cd95a8cjc7d10aa432a49f4@mail.gmail.com \
--to=npelly@google.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=ville.tervo@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).