From: "Stotland, Inga" <inga.stotland@intel.com>
To: "luiz.dentz@gmail.com" <luiz.dentz@gmail.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH BlueZ] shared/shell: Add prompt item to bt_shell_menu structure
Date: Wed, 13 Nov 2019 17:33:13 +0000 [thread overview]
Message-ID: <35ef6466f21e861809ddd89a04019d98ce869918.camel@intel.com> (raw)
In-Reply-To: <20191023054119.7712-1-inga.stotland@intel.com>
Hi Luiz,
On Tue, 2019-10-22 at 22:41 -0700, Inga Stotland wrote:
> This allows to associate specific prompts with main menu
> and submenus thus providing for better navigation when
> submenus are in use.
> ---
> src/shared/shell.c | 3 +++
> src/shared/shell.h | 1 +
> 2 files changed, 4 insertions(+)
>
> diff --git a/src/shared/shell.c b/src/shared/shell.c
> index cfdcc76c4..a821c8d0a 100644
> --- a/src/shared/shell.c
> +++ b/src/shared/shell.c
> @@ -1226,6 +1226,9 @@ bool bt_shell_set_menu(const struct bt_shell_menu *menu)
> if (!data.main)
> data.main = menu;
>
> + if (menu->prompt)
> + bt_shell_set_prompt(menu->prompt);
> +
> return true;
> }
>
> diff --git a/src/shared/shell.h b/src/shared/shell.h
> index e14d58381..a9eee506f 100644
> --- a/src/shared/shell.h
> +++ b/src/shared/shell.h
> @@ -53,6 +53,7 @@ struct bt_shell_menu_entry {
> struct bt_shell_menu {
> const char *name;
> const char *desc;
> + const char *prompt;
> const struct bt_shell_menu_entry entries[];
> };
>
Do you have any comments for this patch?
Best regards,
Inga
next prev parent reply other threads:[~2019-11-13 17:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 5:41 [PATCH BlueZ] shared/shell: Add prompt item to bt_shell_menu structure Inga Stotland
2019-11-13 17:33 ` Stotland, Inga [this message]
2019-11-13 17:46 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35ef6466f21e861809ddd89a04019d98ce869918.camel@intel.com \
--to=inga.stotland@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox