From: Szymon Janc <szymon.janc@codecoup.pl>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: btbcm: Read controller features during configuration
Date: Mon, 12 Jun 2017 11:49:07 +0200 [thread overview]
Message-ID: <3850709.UsqOsZgzJe@ix> (raw)
In-Reply-To: <20170610123229.41513-1-marcel@holtmann.org>
Hi Marcel,
On Saturday, 10 June 2017 14:32:29 CEST Marcel Holtmann wrote:
> Read the Broadcom specific controller features during configuration and
> print them for informational purposes.
>
> < HCI Command: Broadcom Read Controller Features (0x3f|0x006e) plen 0
>
> > HCI Event: Command Complete (0x0e) plen 12
>
> Broadcom Read Controller Features (0x3f|0x006e) ncmd 1
> Status: Success (0x00)
> Features: 0x07 0x00 0x00 0x00 0x00 0x00 0x00 0x00
> Multi-AV transport bandwidth reducer
> WBS SBC
> FW LC-PLC
>
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> ---
> drivers/bluetooth/btbcm.c | 36 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
>
> diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
> index ba3dd2eafc09..24f8c4e93f4e 100644
> --- a/drivers/bluetooth/btbcm.c
> +++ b/drivers/bluetooth/btbcm.c
> @@ -246,6 +246,27 @@ static struct sk_buff *btbcm_read_verbose_config(struct
> hci_dev *hdev) return skb;
> }
>
> +static struct sk_buff *btbcm_read_controller_features(struct hci_dev *hdev)
> +{
> + struct sk_buff *skb;
> +
> + skb = __hci_cmd_sync(hdev, 0xfc6e, 0, NULL, HCI_INIT_TIMEOUT);
> + if (IS_ERR(skb)) {
> + BT_ERR("%s: BCM: Read controller features failed (%ld)",
> + hdev->name, PTR_ERR(skb));
> + return skb;
> + }
> +
> + if (skb->len != 9) {
> + BT_ERR("%s: BCM: Controller features length mismatch",
> + hdev->name);
> + kfree_skb(skb);
> + return ERR_PTR(-EIO);
> + }
> +
> + return skb;
> +}
> +
> static struct sk_buff *btbcm_read_usb_product(struct hci_dev *hdev)
> {
> struct sk_buff *skb;
> @@ -417,6 +438,14 @@ int btbcm_setup_patchram(struct hci_dev *hdev)
> BT_INFO("%s: BCM: chip id %u", hdev->name, skb->data[1]);
> kfree_skb(skb);
>
> + /* Read Controller Features */
> + skb = btbcm_read_controller_features(hdev);
> + if (IS_ERR(skb))
> + return PTR_ERR(skb);
> +
> + BT_INFO("%s: BCM: features 0x%2.2x", hdev->name, skb->data[1]);
> + kfree_skb(skb);
> +
> /* Read Local Name */
> skb = btbcm_read_local_name(hdev);
> if (IS_ERR(skb))
> @@ -540,6 +569,13 @@ int btbcm_setup_apple(struct hci_dev *hdev)
> kfree_skb(skb);
> }
>
> + /* Read Controller Features */
> + skb = btbcm_read_controller_features(hdev);
> + if (!IS_ERR(skb)) {
> + BT_INFO("%s: BCM: features 0x%2.2x", hdev->name, skb->data[1]);
> + kfree_skb(skb);
> + }
> +
> /* Read Local Name */
> skb = btbcm_read_local_name(hdev);
> if (!IS_ERR(skb)) {
Applied to bluetooth-next tree. Thanks.
--
pozdrawiam
Szymon Janc
prev parent reply other threads:[~2017-06-12 9:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-10 12:32 [PATCH] Bluetooth: btbcm: Read controller features during configuration Marcel Holtmann
2017-06-12 9:49 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3850709.UsqOsZgzJe@ix \
--to=szymon.janc@codecoup.pl \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox