From: Szymon Janc <szymon.janc@gmail.com>
To: Jakub Tyszkowski <jakub.tyszkowski@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] android/tester: Explicit set of io capabilities for SSP pairing tests
Date: Wed, 24 Sep 2014 21:40:28 +0200 [thread overview]
Message-ID: <3868693.LsqkFdMOh4@athlon> (raw)
In-Reply-To: <1411547961-30827-1-git-send-email-jakub.tyszkowski@tieto.com>
Hi Jakub,
On Wednesday 24 September 2014 10:39:21 Jakub Tyszkowski wrote:
> Those tests are periodically broken every time default io capabalities
> are changed. This patch sets them explicitely to avoid this breakage.
> ---
> android/tester-bluetooth.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/android/tester-bluetooth.c b/android/tester-bluetooth.c
> index a97e28e..2be824d 100644
> --- a/android/tester-bluetooth.c
> +++ b/android/tester-bluetooth.c
> @@ -448,6 +448,10 @@ static struct bt_action_data no_input_no_output_io_cap
> = { .io_cap = 0x03,
> };
>
> +static struct bt_action_data display_yes_no_io_cap = {
> + .io_cap = 0x01,
> +};
> +
> static uint16_t test_conn_handle = 0;
>
> static void conn_cb(uint16_t handle, void *user_data)
> @@ -1034,6 +1038,7 @@ static struct test_case test_cases[] = {
> CALLBACK_STATE(CB_BT_ADAPTER_STATE_CHANGED, BT_STATE_ON),
> ACTION_SUCCESS(emu_setup_powered_remote_action, NULL),
> ACTION_SUCCESS(emu_set_ssp_mode_action, NULL),
> + ACTION_SUCCESS(emu_set_io_cap, &display_yes_no_io_cap),
> ACTION_SUCCESS(bt_start_discovery_action, NULL),
> CALLBACK_STATE(CB_BT_DISCOVERY_STATE_CHANGED,
> BT_DISCOVERY_STARTED),
> @@ -1057,6 +1062,7 @@ static struct test_case test_cases[] = {
> CALLBACK_STATE(CB_BT_ADAPTER_STATE_CHANGED, BT_STATE_ON),
> ACTION_SUCCESS(emu_setup_powered_remote_action, NULL),
> ACTION_SUCCESS(emu_set_ssp_mode_action, NULL),
> + ACTION_SUCCESS(emu_set_io_cap, &display_yes_no_io_cap),
> ACTION_SUCCESS(bt_start_discovery_action, NULL),
> CALLBACK_STATE(CB_BT_DISCOVERY_STATE_CHANGED,
> BT_DISCOVERY_STARTED),
> @@ -1081,6 +1087,7 @@ static struct test_case test_cases[] = {
> CALLBACK_STATE(CB_BT_ADAPTER_STATE_CHANGED, BT_STATE_ON),
> ACTION_SUCCESS(emu_setup_powered_remote_action, NULL),
> ACTION_SUCCESS(emu_set_ssp_mode_action, NULL),
> + ACTION_SUCCESS(emu_set_io_cap, &display_yes_no_io_cap),
> ACTION_SUCCESS(bt_create_bond_action,
> &prop_test_remote_ble_bdaddr_req),
> CALLBACK_BOND_STATE(BT_BOND_STATE_BONDING,
> @@ -1113,6 +1120,7 @@ static struct test_case test_cases[] = {
> CALLBACK_STATE(CB_BT_ADAPTER_STATE_CHANGED, BT_STATE_ON),
> ACTION_SUCCESS(emu_setup_powered_remote_action, NULL),
> ACTION_SUCCESS(emu_set_ssp_mode_action, NULL),
> + ACTION_SUCCESS(emu_set_io_cap, &display_yes_no_io_cap),
> ACTION_SUCCESS(bt_start_discovery_action, NULL),
> CALLBACK_STATE(CB_BT_DISCOVERY_STATE_CHANGED,
> BT_DISCOVERY_STARTED),
> @@ -1138,6 +1146,7 @@ static struct test_case test_cases[] = {
> CALLBACK_STATE(CB_BT_ADAPTER_STATE_CHANGED, BT_STATE_ON),
> ACTION_SUCCESS(emu_setup_powered_remote_action, NULL),
> ACTION_SUCCESS(emu_set_ssp_mode_action, NULL),
> + ACTION_SUCCESS(emu_set_io_cap, &display_yes_no_io_cap),
> ACTION_SUCCESS(bt_start_discovery_action, NULL),
> CALLBACK_STATE(CB_BT_DISCOVERY_STATE_CHANGED,
> BT_DISCOVERY_STARTED),
Applied, thanks.
--
Szymon K. Janc
szymon.janc@gmail.com
prev parent reply other threads:[~2014-09-24 19:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 8:39 [PATCH] android/tester: Explicit set of io capabilities for SSP pairing tests Jakub Tyszkowski
2014-09-24 19:40 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3868693.LsqkFdMOh4@athlon \
--to=szymon.janc@gmail.com \
--cc=jakub.tyszkowski@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox