From: Szymon Janc <szymon.janc@tieto.com>
To: Jakub Tyszkowski <jakub.tyszkowski@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/3] android/gatt: Fix not setting error properly for exec write
Date: Wed, 10 Dec 2014 14:19:34 +0100 [thread overview]
Message-ID: <39396672.1P6CpeBUxl@leonov> (raw)
In-Reply-To: <1418215251-24018-1-git-send-email-jakub.tyszkowski@tieto.com>
Hi Jakub,
On Wednesday 10 of December 2014 13:40:49 Jakub Tyszkowski wrote:
> We were not properly propagating errors returned by applications.
> ---
> android/gatt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/android/gatt.c b/android/gatt.c
> index e24feb7..18a5092 100644
> --- a/android/gatt.c
> +++ b/android/gatt.c
> @@ -5544,6 +5544,7 @@ static void handle_server_send_response(const void
> *buf, uint16_t len) * gatt_db_attribute_write().
> */
> req = queue_peek_head(conn->device->pending_requests);
> + req->error = err_to_att(cmd->status);
> req->state = REQUEST_DONE;
>
> /*
All patches applied (after fixing typo in last commit message), thanks.
--
BR
Szymon Janc
prev parent reply other threads:[~2014-12-10 13:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 12:40 [PATCH 1/3] android/gatt: Fix not setting error properly for exec write Jakub Tyszkowski
2014-12-10 12:40 ` [PATCH 2/3] android/gatt: Fix passing out of att range errors Jakub Tyszkowski
2014-12-10 12:40 ` [PATCH 3/3] android/pts: Update gatt serwer results Jakub Tyszkowski
2014-12-10 13:19 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39396672.1P6CpeBUxl@leonov \
--to=szymon.janc@tieto.com \
--cc=jakub.tyszkowski@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).