Linux bluetooth development
 help / color / mirror / Atom feed
From: Nicolas Werner <nicolas.werner@gmx.net>
To: linux-bluetooth@vger.kernel.org
Subject: [RFC][PATCH BlueZ] sixaxis: Differing device name between usb and bluetooth connection
Date: Sat, 04 Feb 2017 19:15:50 +0100	[thread overview]
Message-ID: <3969021.WDePWYxnyn@gentooasus> (raw)

BlueZ sets the device name of Dual Shock 3 controller to "PLAYSTATION(R)3 
Controller". When you connect the same controller via USB it is set to "Sony 
PLAYSTATION(R)3 Controller".

It seems that at least some games fail to recognize the controller as a Dual 
Shock 3/sixaxis controller and don't load the default mapping for PlayStation 
controllers, if the name doesn't contain the Sony part. Also I don't see a 
reason to use a different name, when connecting via Bluetooth.

I noticed this with "The Binding of Isaac: Rebirth" and it seems, that Steam 
also recognizes the controller better after the patch, although I'm not 
confident, if I can parse the controller configuration dialog correctly.
I don't know, if this breaks anything, because it depends on the current name.

The attached patch changes the device name set when pairing to match the 
device name, when connected via USB.

Nicolas Werner

--- a/plugins/sixaxis.c
+++ b/plugins/sixaxis.c
@@ -56,7 +56,7 @@
        uint16_t version;
 } devices[] = {
        {
-               .name = "PLAYSTATION(R)3 Controller",
+               .name = "Sony PLAYSTATION(R)3 Controller",
                .source = 0x0002,
                .vid = 0x054c,
                .pid = 0x0268,


             reply	other threads:[~2017-02-04 18:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-04 18:15 Nicolas Werner [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-02-04 18:16 [RFC][PATCH BlueZ] sixaxis: Differing device name between usb and bluetooth connection Nicolas Werner
2017-08-04 20:29 ` Nicolas Werner
2017-08-07  6:56   ` Szymon Janc
2017-08-23 20:21     ` Bastien Nocera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3969021.WDePWYxnyn@gentooasus \
    --to=nicolas.werner@gmx.net \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox