From: "Gix, Brian" <brian.gix@intel.com>
To: "linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
"Stotland, Inga" <inga.stotland@intel.com>
Subject: Re: [PATCH BlueZ] shared/timeout-ell: Fix timeout_add() implementation
Date: Thu, 22 Apr 2021 21:31:22 +0000 [thread overview]
Message-ID: <3d376e1dfc031af9d3d5778e8d8084f9d254ffb1.camel@intel.com> (raw)
In-Reply-To: <20210415050347.253831-1-inga.stotland@intel.com>
Applied, Thanks
On Wed, 2021-04-14 at 22:03 -0700, Inga Stotland wrote:
> Since timeout_add() expects the timeout in milliseconds, the correct
> ELL primitive to call is l_timeout_create_ms()
> ---
> src/shared/timeout-ell.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/shared/timeout-ell.c b/src/shared/timeout-ell.c
> index 6416d8590..026286926 100644
> --- a/src/shared/timeout-ell.c
> +++ b/src/shared/timeout-ell.c
> @@ -68,7 +68,7 @@ unsigned int timeout_add(unsigned int timeout, timeout_func_t func,
> data->timeout = timeout;
>
> while (id == 0 && tries < 3) {
> - to = l_timeout_create(timeout, timeout_callback,
> + to = l_timeout_create_ms(timeout, timeout_callback,
> data, timeout_destroy);
> if (!to)
> break;
prev parent reply other threads:[~2021-04-22 21:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 5:03 [PATCH BlueZ] shared/timeout-ell: Fix timeout_add() implementation Inga Stotland
2021-04-15 5:43 ` [BlueZ] " bluez.test.bot
2021-04-22 21:31 ` Gix, Brian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d376e1dfc031af9d3d5778e8d8084f9d254ffb1.camel@intel.com \
--to=brian.gix@intel.com \
--cc=inga.stotland@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox