public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: James Courtier-Dutton <James@superbug.demon.co.uk>
To: bluez-devel@lists.sourceforge.net
Subject: [Bluez-devel] [PATCH] Fix to enable bluez SCO USB urbs.
Date: Fri, 27 Feb 2004 23:57:28 +0000	[thread overview]
Message-ID: <403FD968.6010004@superbug.demon.co.uk> (raw)

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

Here is a patch for /usr/src/linux-2.6.3/drivers/bluetooth/hci_usb.c

Without the interval set, the latest kernel 2.6.3 usb code will reject 
the usb_submit_urb().

Without this patch no ISOC urbs are submitted, and thus no SCO data is 
passed.

The proper fix would really be to only enable these when a SCO 
connection is actually open.

Cheers
James

[-- Attachment #2: sco-patch.diff --]
[-- Type: text/x-patch, Size: 657 bytes --]

--- hci_usb.c.org	2004-02-26 20:36:06.000000000 +0000
+++ hci_usb.c	2004-02-27 23:49:08.273537136 +0000
@@ -263,6 +263,7 @@
 
 	urb->context  = husb;
 	urb->dev      = husb->udev;
+	urb->interval = husb->isoc_in_ep->desc.bInterval;
 	urb->pipe     = usb_rcvisocpipe(husb->udev, husb->isoc_in_ep->desc.bEndpointAddress);
 	urb->complete = hci_usb_rx_complete;
 
@@ -490,6 +491,7 @@
 	
 	urb->context  = husb;
 	urb->dev      = husb->udev;
+	urb->interval = husb->isoc_out_ep->desc.bInterval;
 	urb->pipe     = usb_sndisocpipe(husb->udev, husb->isoc_out_ep->desc.bEndpointAddress);
 	urb->complete = hci_usb_tx_complete;
 	urb->transfer_flags = URB_ISO_ASAP;

             reply	other threads:[~2004-02-27 23:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-27 23:57 James Courtier-Dutton [this message]
2004-02-28 12:52 ` [Bluez-devel] [PATCH] Fix to enable bluez SCO USB urbs Marcel Holtmann
2004-02-29  2:40   ` James Courtier-Dutton
2004-02-29  2:39     ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=403FD968.6010004@superbug.demon.co.uk \
    --to=james@superbug.demon.co.uk \
    --cc=bluez-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox