Linux bluetooth development
 help / color / mirror / Atom feed
From: Szymon Janc <szymon.janc@tieto.com>
To: Grzegorz Kolodziejczyk <grzegorz.kolodziejczyk@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/6] android/tester: Style fix
Date: Mon, 29 Sep 2014 16:15:17 +0200	[thread overview]
Message-ID: <4132233.Jt0eWaURL5@uw000953> (raw)
In-Reply-To: <1411653793-5254-1-git-send-email-grzegorz.kolodziejczyk@tieto.com>

Hi Grzegorz,

On Thursday 25 of September 2014 16:03:08 Grzegorz Kolodziejczyk wrote:
> ---
>  android/tester-main.c | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/android/tester-main.c b/android/tester-main.c
> index b65029a..081a1ce 100644
> --- a/android/tester-main.c
> +++ b/android/tester-main.c
> @@ -440,8 +440,7 @@ static bool match_data(struct step *step)
>  			return false;
>  		}
>  
> -		if (exp->callback_result.state !=
> -						step->callback_result.state) {
> +		if (exp->callback_result.state != step->callback_result.state) {
>  			tester_debug("Callback state don't match");
>  			return false;
>  		}
> @@ -452,8 +451,7 @@ static bool match_data(struct step *step)
>  			return false;
>  		}
>  
> -		if (exp->callback_result.mode !=
> -						step->callback_result.mode) {
> +		if (exp->callback_result.mode != step->callback_result.mode) {
>  			tester_debug("Callback mode don't match");
>  			return false;
>  		}
> @@ -489,7 +487,7 @@ static bool match_data(struct step *step)
>  		}
>  
>  		if (exp->callback_result.app_id !=
> -					step->callback_result.app_id) {
> +						step->callback_result.app_id) {
>  			tester_debug("Callback app_id don't match");
>  			return false;
>  		}
> @@ -874,8 +872,8 @@ static void bond_state_changed_cb(bt_status_t status,
>  
>  	/* Utilize property verification mechanism for bdaddr */
>  	step->callback_result.num_properties = 1;
> -	step->callback_result.properties = create_property(BT_PROPERTY_BDADDR,
> -						remote_bd_addr,
> +	step->callback_result.properties =
> +			create_property(BT_PROPERTY_BDADDR, remote_bd_addr,
>  						sizeof(*remote_bd_addr));
>  
>  	step->callback = CB_BT_BOND_STATE_CHANGED;
> 

Patches 1-3 and 5 applied (with some minor fixes), thanks.
For rest please send updates as discussed offline.

-- 
Best regards, 
Szymon Janc

      parent reply	other threads:[~2014-09-29 14:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-25 14:03 [PATCH 1/6] android/tester: Style fix Grzegorz Kolodziejczyk
2014-09-25 14:03 ` [PATCH 2/6] android/tester: Make client and server id unified Grzegorz Kolodziejczyk
2014-09-25 14:03 ` [PATCH 3/6] android/tester: Add GATT Server basic test cases Grzegorz Kolodziejczyk
2014-09-25 14:03 ` [PATCH 4/6] android/tester: Add GATT server connect successful test case Grzegorz Kolodziejczyk
2014-09-25 14:03 ` [PATCH 5/6] android/tester: Make tester debug logs verbose Grzegorz Kolodziejczyk
2014-09-25 14:03 ` [PATCH 6/6] android/tester: Add GATT server disconnect successful test case Grzegorz Kolodziejczyk
2014-09-29 14:15 ` Szymon Janc [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4132233.Jt0eWaURL5@uw000953 \
    --to=szymon.janc@tieto.com \
    --cc=grzegorz.kolodziejczyk@tieto.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox