From: Szymon Janc <szymon.janc@tieto.com>
To: Johan Hedberg <johan.hedberg@gmail.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH v3 05/18] oob: Allow to register pairing complete callback
Date: Mon, 24 Sep 2012 13:28:51 +0200 [thread overview]
Message-ID: <4152119.R0jHNBc7xV@uw000953> (raw)
In-Reply-To: <20120924090626.GB19184@x220>
On Monday 24 of September 2012 12:06:26 Johan Hedberg wrote:
> Hi Szymon,
Hi Johan,
> On Fri, Sep 21, 2012, Szymon Janc wrote:
> > --- a/src/mgmt.c
> > +++ b/src/mgmt.c
> > @@ -1193,6 +1193,7 @@ static void pair_device_complete(int sk, uint16_t index, uint8_t status,
> > info = &controllers[index];
> >
> > bonding_complete(info, &rp->addr.bdaddr, status);
> > + oob_pairing_complete(&info->bdaddr, &rp->addr.bdaddr, status);
> > }
>
> Can't we be a bit smarter than always notifying the oob code. Don't we
> e.g. have the possibility to look at the IO capabilities used in the
> pairing process or some other means from which we can conclude that this
> was an OOB-based pairing that completed?
Hash and randomizer are optional tags (only address is mandatory) so there
might be only OOB discovery and in-band pairing (OOB data present flag not
set in iocapa).
I could try to make OOB callbacks registering mechanism a bit more runtime
aware (register/unregister on-demand basis) or bit-more compile time aware
(hide after a macro and enable only if one of oob plugin is build).
Not sure if this would not over-complicate that code to much... opinions?
>
> Johan
--
BR
Szymon Janc
next prev parent reply other threads:[~2012-09-24 11:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 12:36 [PATCH v3 00/18] neard plugin Szymon Janc
2012-09-21 12:36 ` [PATCH v3 01/18] Add initial neard plugin implementation Szymon Janc
2012-09-21 12:36 ` [PATCH v3 02/18] eir: Add support for parsing SSP hash and randomizer Szymon Janc
2012-09-24 8:08 ` Johan Hedberg
2012-09-24 10:20 ` Szymon Janc
2012-09-21 12:36 ` [PATCH v3 03/18] eir: Store class in struct eir_data as uint32_t Szymon Janc
2012-09-21 12:36 ` [PATCH v3 04/18] eir: Add eir_parse_oob function Szymon Janc
2012-09-21 12:36 ` [PATCH v3 05/18] oob: Allow to register pairing complete callback Szymon Janc
2012-09-24 9:06 ` Johan Hedberg
2012-09-24 11:28 ` Szymon Janc [this message]
2012-09-21 12:36 ` [PATCH v3 06/18] Handle missing randomizer in mgmt_add_remote_oob_data Szymon Janc
2012-09-21 12:36 ` [PATCH v3 07/18] neard: Implement PushOOB function Szymon Janc
2012-09-24 9:09 ` Johan Hedberg
2012-09-24 14:38 ` Szymon Janc
2012-09-21 12:36 ` [PATCH v3 08/18] eir: Add support creating EIR with hash and randomizer fields Szymon Janc
2012-09-21 12:36 ` [PATCH v3 09/18] eir: Add support for creating EIR with CoD field Szymon Janc
2012-09-21 12:36 ` [PATCH v3 10/18] eir: Rename eir_create to eir_create_oob Szymon Janc
2012-09-21 12:36 ` [PATCH v3 11/18] eir: Remove support for creating EIR with tx_power fields Szymon Janc
2012-09-21 12:36 ` [PATCH v3 12/18] eir: Return number of bytes written by eir_create_oob Szymon Janc
2012-09-21 12:36 ` [PATCH v3 13/18] eir: Remove struct uuid_info Szymon Janc
2012-09-21 12:36 ` [PATCH v3 14/18] eir: Add support for creating proper OOB EIR Szymon Janc
2012-09-21 12:36 ` [PATCH v3 15/18] adapter: Add btd_adapter_get_services function Szymon Janc
2012-09-21 12:36 ` [PATCH v3 16/18] adapter: Rename btd_adapter_get_class to btd_adapter_read_class Szymon Janc
2012-09-21 12:36 ` [PATCH v3 17/18] adapter: Add btd_adapter_get_class function Szymon Janc
2012-09-21 12:36 ` [PATCH v3 18/18] neard: Implement RequestOOB function Szymon Janc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4152119.R0jHNBc7xV@uw000953 \
--to=szymon.janc@tieto.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox