Re: [Bluez-devel] BT-Sco

Thomas Lußnig
2004-11-26T16:33:01Z

>the source code size of this version is amazing, but the coding style is
>crap. Sorry to say that.
>
>
For the current version the size is to large but i thought of extending
the source to allow multiple Headsets.
Than it does not grow much since it already use an record and no static
variables.

>Don't use {{{ and include some newlines. Actually follow the kernel
>coding style.
>
>
The {{{ i use for folding marks they can be replaced with { same as with
}}} and }.

>Why do you rewrite the function from libbluetooth and libasound. Simply
>use them, because these are shared library and they are loaded anyway.
>
>
1. What function of libbluetooth ? The only bluetooth function in wich
would be useable is geting
the local mac and the remove channel and string2adress conversion. wich
is in no relation to the
size the binary would grow. With the same ground you could ask why i
rewrite the asound part.
Here the ground is even more interesting.
1. I save many file open / close
2. It run faster
3. If the sound device support async io or even only signaling if there
are new mixer data it can be done without
poll.

The ground i rewrite the original was so that i can use these code more
easy to add it so other programms like kphone
and use the button with switch sco on/off for accepting phone calls.

Cu Thomas