Re: [Bluez-devel] BT-Sco

Brad Midgley
2004-11-28T03:07:27Z

Thomas,

> here is an optimized version of btsco.c it es rewriten for Linux only.
> Is does not need libbluetooth or libasound.
> It is event driven but currently use fixed MAC
>
> Any idea's are welcomed.

I finally looked at this. You've put some time into it I can see. If you
look at the bug list at our sourceforge page, you'll see we actually
want stronger ties to alsa libs (possibly using their userspace driver).
Working toward multiple headsets is good but if the struct is global
it's a missed opportunity.

I can understand the approach Linus takes to patches. He likes
incremental patches that solve a single well-defined problem. It's
easier to look for correctness.

You should choose one of the many problems with what we've got, discuss
it here, and take a shortest-distance approach to solving it.

The unconventional stuff like "{{{" and "if(-1 == ioctl(...))" work fine
but distract the reader from what the code is doing. After all, this
stuff has to be read by people, not just the compiler.

Brad