From: Szymon Janc <szymon.janc@gmail.com>
To: Jakub Tyszkowski <jakub.tyszkowski@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 01/11] android/unit: Fix checking for expected termination
Date: Tue, 04 Feb 2014 21:37:33 +0100 [thread overview]
Message-ID: <4257402.zuGhVzPUGX@athlon> (raw)
In-Reply-To: <1391524749-2518-1-git-send-email-jakub.tyszkowski@tieto.com>
Hi Jakub,
On Tuesday 04 February 2014 15:38:59 Jakub Tyszkowski wrote:
> This fix makes sure that when signalled termination is expected,
> it actually happens. If IPC termination is expected no response will be
> sent, so cmd_watch will never be executed. But if it is executed when
> expecting termination, its a failure.
> ---
> android/test-ipc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/android/test-ipc.c b/android/test-ipc.c
> index 8af5739..d0f3f6b 100644
> --- a/android/test-ipc.c
> +++ b/android/test-ipc.c
> @@ -82,6 +82,8 @@ static gboolean cmd_watch(GIOChannel *io, GIOCondition
> cond, uint8_t buf[128];
> int sk;
>
> + g_assert(test_data->expected_signal == 0);
> +
> if (cond & (G_IO_HUP | G_IO_ERR | G_IO_NVAL)) {
> g_assert(FALSE);
> return FALSE;
All patches are now upstream, thanks.
--
Szymon K. Janc
szymon.janc@gmail.com
prev parent reply other threads:[~2014-02-04 20:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 14:38 [PATCH 01/11] android/unit: Fix checking for expected termination Jakub Tyszkowski
2014-02-04 14:39 ` [PATCH 02/11] android/unit: Rename cmd handler Jakub Tyszkowski
2014-02-04 14:39 ` [PATCH 03/11] android/unit: Add test cases for proper handler calls Jakub Tyszkowski
2014-02-04 14:39 ` [PATCH 04/11] android/unit: Add case for opcode without handler Jakub Tyszkowski
2014-02-04 14:39 ` [PATCH 05/11] android/unit: Add support for variable length data Jakub Tyszkowski
2014-02-04 14:39 ` [PATCH 06/11] android/unit: Add test case for variable sized data Jakub Tyszkowski
2014-02-04 14:39 ` [PATCH 07/11] android/unit: Add another " Jakub Tyszkowski
2014-02-04 14:39 ` [PATCH 08/11] android/unit: Add case for out of range service Jakub Tyszkowski
2014-02-04 14:39 ` [PATCH 09/11] android/unit: Add negative case for msg size verification Jakub Tyszkowski
2014-02-04 14:39 ` [PATCH 10/11] android/unit: Add case for sending incomplete header Jakub Tyszkowski
2014-02-04 14:39 ` [PATCH 11/11] android/unit: Add cases for msg size verification Jakub Tyszkowski
2014-02-04 20:37 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4257402.zuGhVzPUGX@athlon \
--to=szymon.janc@gmail.com \
--cc=jakub.tyszkowski@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox