From: Brad Midgley <bmidgley@xmission.com>
To: bluez-devel@lists.sourceforge.net
Subject: Re: [Bluez-devel] Re: a2play code that is working
Date: Tue, 26 Apr 2005 10:12:07 -0600 [thread overview]
Message-ID: <426E6857.6010204@xmission.com> (raw)
In-Reply-To: <1114527365.10706.288.camel@pegasus>
Marcel
> Now commenting on the change itself. The "struct sbc_frame_header"
> should not placed inside the sbc.h header file. This is the API
> interface and we don't need a definition of the SBC file format there.
> If you wanna modify the additional SBC parameters add them to sbc_struct
> and set them there. Please fix this.
>
> Also a library should not use printf() at all. Remove them and improve
> the return values to match -ENOMEM etc.
I will clean this up (I was being lazy and rolling in submissions
without reworking them enough)
Brad
-------------------------------------------------------
SF.Net email is sponsored by: Tell us your software development plans!
Take this survey and enter to win a one-year sub to SourceForge.net
Plus IDC's 2005 look-ahead and a copy of this survey
Click here to start! http://www.idcswdc.com/cgi-bin/survey?id=105hix
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel
next prev parent reply other threads:[~2005-04-26 16:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <426C05D9.6090100@xmission.com>
2005-04-26 12:21 ` [Bluez-devel] Re: a2play code that is working Mayank Batra
2005-04-26 14:56 ` Marcel Holtmann
2005-04-26 16:12 ` Brad Midgley [this message]
2005-04-26 16:48 ` Brad Midgley
2005-04-26 16:57 ` Marcel Holtmann
2005-04-26 17:02 ` Brad Midgley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=426E6857.6010204@xmission.com \
--to=bmidgley@xmission.com \
--cc=bluez-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox