From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <434C164E.5090805@csr.com> From: Steven Singer MIME-Version: 1.0 To: bluez-devel@lists.sourceforge.net Subject: Re: [Bluez-devel] hcid patch (remote name and connections) References: <1129053693.8229.1.camel@localhost.localdomain> <20051011192801.GA12571@localhost.localdomain> In-Reply-To: <20051011192801.GA12571@localhost.localdomain> Content-Type: text/plain; charset=us-ascii Sender: bluez-devel-admin@lists.sourceforge.net Errors-To: bluez-devel-admin@lists.sourceforge.net Reply-To: bluez-devel@lists.sourceforge.net List-Unsubscribe: , List-Id: BlueZ development List-Post: List-Help: List-Subscribe: , List-Archive: Date: Tue, 11 Oct 2005 20:45:18 +0100 Johan Hedberg wrote: > + id = malloc(sizeof(guint)); I'd recommend encapsulating the id in a structure rather than allocating sizeof(guint). It doesn't cost you much time now and if, in the future, you ever need to store any more information then the structure's already there. I noticed you already have a structure struct hci_dbus_data which contains just an integer. Did you mean to use that here or are they logically separate types (that just happen to be the same at the moment)? - Steven -- This message has been scanned for viruses by BlackSpider MailControl - www.blackspider.com ------------------------------------------------------- This SF.Net email is sponsored by: Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl _______________________________________________ Bluez-devel mailing list Bluez-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bluez-devel