From: Brad Midgley <bmidgley@xmission.com>
To: bluez-devel@lists.sourceforge.net
Subject: Re: [Bluez-devel] fixed-point sbc decoder
Date: Wed, 26 Oct 2005 23:33:48 -0600 [thread overview]
Message-ID: <436066BC.4060501@xmission.com> (raw)
In-Reply-To: <43604483.7070109@xmission.com>
Victor,
>>I'll take a look in coming days.
fwiw, I committed fixed point decoding such as it is to cvs after
finding and eliminating some overflow problems. it's noisy but at least
functional. so you can just check it out of cvs (I didn't want to commit
what I had before that was nonfunctional but at least this is borderline)
> #define SP8(val) (val/(1<<SCALE_PROTO8_TBL))
actually, I found this needs to look like
#define SP8(val) (((int32_t)val)/(1<<SCALE_PROTO8_TBL))
I guess because all the literals in the array init look like they're
unsigned. This kind of fix may need to be applied in a few other places.
I am very proud of the latest optimization. I eliminated the shift/copy
of the main array by reordering it. The result is going to benefit from
unrolling since I was also able to make the array access into sbc_proto
always the same in every pass.
brad
-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc.
Get Certified Today * Register for a JBoss Training Course
Free Certification Exam for All Training Attendees Through End of 2005
Visit http://www.jboss.com/services/certification for more information
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel
next prev parent reply other threads:[~2005-10-27 5:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-25 7:28 [Bluez-devel] fixed-point sbc decoder Victor Shcherbatyuk
2005-10-27 3:07 ` Brad Midgley
2005-10-27 5:33 ` Brad Midgley [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-10-24 22:29 Brad Midgley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=436066BC.4060501@xmission.com \
--to=bmidgley@xmission.com \
--cc=bluez-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).