Re: [PATCH 0/5] Wifi & Bluetooth on LG G Watch R

Bjorn Andersson
2022-02-25T21:55:11Z

On Fri 25 Feb 12:19 PST 2022, Luca Weiss wrote:

> Hi Bjorn
>
> On Donnerstag, 24. Februar 2022 05:15:06 CET Bjorn Andersson wrote:
> > On Wed 16 Feb 15:24 CST 2022, Luca Weiss wrote:
> > > This series adds the BCM43430A0 chip providing Bluetooth & Wifi on the
> > > LG G Watch R.
> >
> > I picked the dts changes, but would prefer that the other two changes
> > goes through the BT tree. I see that you haven't copied Marcel on the
> > dt-binding change though, so please resubmit those two patches together.
>
> Thank you, will resubmit the first two!
>
> Just to be clear, as far as I understand each patch gets sent based on its own
> get_maintainer.pl, and the cover letter gets sent to the superset of all
> individual patch recipients?

It's rather annoying to be maintainer and only get 1-2 patches out of a
larger series and having to browse lore.kernel.org to find the rest. So
based on that I tend to make sure that everyone is Cc'ed on all patches
in my series.

And then there's the general advice that if there isn't a strong
dependency between the patches, it might be better to just submit them
separately in the first place. Simply to make it easier for each
maintainer to merge your patches.

> I'm using this script that's largely based on something I found online a while
> ago
> https://github.com/z3ntu/dotfiles/blob/master/scripts/usr/local/bin/cocci_cc
>
> Also just checked and Marcel isn't listed as maintainer of the relevant dt
> bindings in MAINTAINERS, maybe they should get added there?
>

In general I think the DT bindings goes through the relevant subsystem
maintainer, so I would suggest that you post a patch. If for some reason
Marcel shouldn't merge BT related DT patches, then the discussion that
follows will make that clear and you could make sure that MAINTAINERS
reflects the outcome.

Regards,
Bjorn

> (also CCed Marcel on this email)
>
> Regards
> Luca
>
> >
> > Thanks,
> > Bjorn
> >
> > > Luca Weiss (5):
> > > dt-bindings: bluetooth: broadcom: add BCM43430A0
> > > Bluetooth: hci_bcm: add BCM43430A0
> > > ARM: dts: qcom: msm8226: Add pinctrl for sdhci nodes
> > > ARM: dts: qcom: apq8026-lg-lenok: Add Wifi
> > > ARM: dts: qcom: apq8026-lg-lenok: Add Bluetooth
> > >
> > > .../bindings/net/broadcom-bluetooth.yaml | 1 +
> > > arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts | 98 ++++++++++++++++---
> > > arch/arm/boot/dts/qcom-msm8226.dtsi | 57 +++++++++++
> > > drivers/bluetooth/hci_bcm.c | 1 +
> > > 4 files changed, 144 insertions(+), 13 deletions(-)
>
>
>
>