[Bluez-devel] snd-bt-sco.ko and ACPI suspend

[Bluez-devel] snd-bt-sco.ko and ACPI suspend

[Stefan Scheler]

[-- Attachment #1.1: Type: text/plain, Size: 157 bytes --]

Hello,

currently snd-bt-sco.ko is breaking ACPI suspend. So can we please apply
a minor patch like the following to CVS and fix this? Thanks.

Stefan

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: fix_acpi_suspend_s3.diff --]
[-- Type: text/x-patch; name="fix_acpi_suspend_s3.diff", Size: 409 bytes --]

Signed-off-by: Stefan Scheler <sscheler@suse.de>

diff -ru btsco/kernel/btsco.c btsco/kernel/btsco.c
--- btsco/kernel/btsco.c	2006-03-10 12:45:25.000000000 +0100
+++ btsco/kernel/btsco.c	2006-03-10 12:52:15.000000000 +0100
@@ -891,6 +891,11 @@
 	up(&bt_sco->thread_sem);
 
 	do {
+
+#ifdef CONFIG_PM
+		try_to_freeze();
+#endif
+
 		if (signal_pending(current))
 			flush_signals(current);
 

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [Bluez-devel] snd-bt-sco.ko and ACPI suspend

[David Woodhouse]

On Fri, 2006-03-10 at 13:29 +0100, Stefan Scheler wrote:
> currently snd-bt-sco.ko is breaking ACPI suspend. So can we please apply
> a minor patch like the following to CVS and fix this? Thanks.

If it had been merged into Linus' kernel tree, that would have happened
already long ago. Why hasn't it been merged?

-- 
dwmw2



-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] snd-bt-sco.ko and ACPI suspend

[Brad Midgley]

David

>>currently snd-bt-sco.ko is breaking ACPI suspend. So can we please apply
>>a minor patch like the following to CVS and fix this? Thanks.
> 
> If it had been merged into Linus' kernel tree, that would have happened
> already long ago. Why hasn't it been merged?

I patched cvs.

I believe it would take more work to get it to the stage that it would
be acceptable for inclusion. Probably as much effort as just moving it
entirely to userspace, where it (arguably) belongs.

Brad


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] snd-bt-sco.ko and ACPI suspend

[Brad Midgley]

Stefan

doh. If we had been included then we wouldn't have to worry about the
older api for try_to_freeze. Can you give me a safer patch that will
work with 2.6.12 for example?

brad

> Signed-off-by: Stefan Scheler <sscheler@suse.de>
> 
> diff -ru btsco/kernel/btsco.c btsco/kernel/btsco.c
> --- btsco/kernel/btsco.c	2006-03-10 12:45:25.000000000 +0100
> +++ btsco/kernel/btsco.c	2006-03-10 12:52:15.000000000 +0100
> @@ -891,6 +891,11 @@
>  	up(&bt_sco->thread_sem);
>  
>  	do {
> +
> +#ifdef CONFIG_PM
> +		try_to_freeze();
> +#endif
> +
>  		if (signal_pending(current))
>  			flush_signals(current);
>  



-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] snd-bt-sco.ko and ACPI suspend

[Stefan Scheler]

[-- Attachment #1.1: Type: text/plain, Size: 319 bytes --]

> Can you give me a safer patch that will work with 2.6.12 for example?

Well, yes. I also removed the unnecessary CONFIG_PM-define.
try_to_freeze() is also available with power management disabled as I
found out. The following patch has been tested with 2.6.11.4 and I
didn't notice any ill effects.

Stefan


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: fix_suspend_v2.diff --]
[-- Type: text/x-patch; name="fix_suspend_v2.diff", Size: 433 bytes --]

diff -ru btsco.orig/kernel/btsco.c btsco/kernel/btsco.c
--- btsco.orig/kernel/btsco.c	2006-03-11 11:52:08.000000000 +0100
+++ btsco/kernel/btsco.c	2006-03-11 11:52:57.000000000 +0100
@@ -892,8 +892,11 @@
 
 	do {
 
-#ifdef CONFIG_PM
+#if (LINUX_VERSION_CODE > KERNEL_VERSION(2,6,12))
 		try_to_freeze();
+#else
+		if (current->flags & PF_FREEZE)
+			refrigerator(PF_FREEZE);
 #endif
 
 		if (signal_pending(current))

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]

Re: [Bluez-devel] snd-bt-sco.ko and ACPI suspend

[Brad Midgley]

Stefan

>>Can you give me a safer patch that will work with 2.6.12 for example?
> 
> Well, yes. I also removed the unnecessary CONFIG_PM-define.

thanks for the quick fix :) I've applied it.

Brad


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel