From: Szymon Janc <szymon.janc@tieto.com>
To: Johan Hedberg <johan.hedberg@gmail.com>
Cc: Bharat Panda <bharat.panda@samsung.com>,
linux-bluetooth@vger.kernel.org, cpgs@samsung.com
Subject: Re: [PATCH ] monitor: Add AVDTP support to btmon
Date: Fri, 20 Mar 2015 13:17:46 +0100 [thread overview]
Message-ID: <4447842.jsmiU4PHsP@leonov> (raw)
In-Reply-To: <20150320120459.GA20347@t440s.ger.corp.intel.com>
Hi,
On Friday 20 of March 2015 14:04:59 Johan Hedberg wrote:
> Hi Bharat,
>
> On Fri, Mar 20, 2015, Bharat Panda wrote:
> > +static char *pt2str(uint8_t hdr)
>
> This should be static const char *
>
> > +static char *mt2str(uint8_t hdr)
>
> Same here.
>
> > +static char *sig2str(uint8_t tsid)
>
> And here.
>
> Johan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth"
> in the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
While on this it would be really nice to have option for filtering out AVDTP
from btmon output (ideally that would be for A2DP data traffic but we are not
there yet).
--
BR
Szymon Janc
next prev parent reply other threads:[~2015-03-20 12:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 11:36 [PATCH ] monitor: Add AVDTP support to btmon Bharat Panda
2015-03-20 12:04 ` Johan Hedberg
2015-03-20 12:17 ` Szymon Janc [this message]
2015-03-20 13:32 ` Bharat Bhusan Panda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4447842.jsmiU4PHsP@leonov \
--to=szymon.janc@tieto.com \
--cc=bharat.panda@samsung.com \
--cc=cpgs@samsung.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox